GithubHelp home page GithubHelp logo

afcp's Issues

Mistake in code of Listing 6.4: Printing of LCS

The code for Printing the Longest Common Subsequence as given in the book:

void printLCS(int i, int j) {
    if (i == 0 || j == 0) {
        return;
    }

    if (C[i][j] == C[i - 1][j - 1] + 1) {
        printLCS(i - 1, j - 1);
        printf("%d ", X[i - 1]);
    } else if (C[i][j] == C[i - 1][j]) {
        printLCS(i - 1, j);
    } else {
        printLCS(i, j - 1);
    }
}

But I think the order of the conditionals is wrong as

C[i][j] == C[i - 1][j - 1] + 1

May be satisfied even at i and j's with no common letters hence giving the wrong LCS when using this function with the longer word.

The correct code should be:

void printLCS(int i, int j) {
    if (i == 0 || j == 0) {
        return;
    }

    if (C[i][j] == C[i - 1][j]) {
        printLCS(i - 1, j);
    } else if (C[i][j] == C[i][j-1]){
        printLCS(i, j - 1);
    }
    else {
        printLCS(i - 1, j - 1);
        printf("%d ", X[i - 1]);
    }
}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.