Describe the problem

ci-studio-common has a buildkite-agent-hook bash script that does some vault-util configuration for accounts and pulls in secrets as environment variables when run within specific environments. We should move this logic directly to the corresponding go projects since these scripts will no longer be used in the near future.

We can find remnants of these scripts being used within Expeditor when it initializes docker and macos executors within buildkite pipelines.

On macos, when using vault, the expectation is sourcing https://github.com/chef/ci-studio-common/blob/master/buildkite-agent-hooks/ci-studio-common.sh will export the appropriate variables (assuming the VAULT_UTIL_SECRETS is set correctly).

However, in order to consume these, any script that relies on these variables needs to run eval "$(vault-util fetch-secret-env)" in order to get them. This was tested on macos with default bash (3.x) and brew installed bash (4.x).

On entering the studio in A2 you will see:

/hab/pkgs/chef/ci-studio-common/1.1.18/20180816000854/bin/studio-common: line 31: curl: command not found

Problem

There’s a bug with some usage of theinstall-tool utility. Right now it supports passing in multiple tools (e.g. install-tool hab aws), but this breaks the desired functionality of being able to specify versions (e.g. install-tool terraform 0.10.x).

Solution

Split single calls (install-tool hab aws) into two calls (install-tool hab and install-tool aws)

When trying to execute:

hab-verify in-studio "cd /foo; touch bar"

You will get an error:

/home/travis/ci-studio-common/bin/hab-verify: line 31: integration: command not found