chenhengjie123 / coverstory Goto Github PK

I've moved both patterns into defaults
(http://codereview.appspot.com/1441), but we need to add something to the
prefs window to allow someone to modify the list.

What steps will reproduce the problem?
1. Run CoverStory
2. Try to open anyway a folder with .GCOV files only
3.

What is the expected output? What do you see instead?
A document window for folder with all GCOV files loaded should be opened, 
instead empty document is opened

What version of the product are you using? On what operating system?
CoverStory 4.4.1. Mac OS X 10.8.4

Please provide any additional information below.
patch with fix is attached

1. launch coverstory
2. load some data
3. move the splitter so the file list is larger
4. hit reload data

the animation that shows/hides the spinner is using a stale size, it need
to get the size that the spinner really is.  (do we care if they move the
splitter during the load?)

What steps will reproduce the problem?
1. Have 300 files or more in one directory.
2. Open the directory.
3. CoverStory never ends the loading.

What is the expected output? What do you see instead?

The files should be successfully loaded.

What version of the product are you using? On what operating system?

Current version from trunk (October 30, 2012). Mac Lion 10.7.5

Please provide any additional information below.

When debugging the code, the program is stuck in GTMScriptRunner class when 
waiting for the result of the "gcov" script. I believe it is stuck because the 
contents of standard error pipe are not read and the pipe is full. This gets 
fixed if error ouput is ignored (redirected to CoverStory standard error).
This error pipe overflows probably because of issue 
http://code.google.com/p/coverstory/issues/detail?id=37.

Recommended fix - read error output periodically or redirect it to a file, do 
not wait until the task is finished.

What steps will reproduce the problem?
1. Add a folder with complex structure and huge amount of coverage files inside
2. Try to work with UI during files loading progressed
3.

What is the expected output? What do you see instead?
UI should work fluently, but it is unresponsive very often

What version of the product are you using? On what operating system?
CoverStory 4.4.1. Mac OS X 10.8.4

Please provide any additional information below.
patch with fix is attached

Greg hit this today, we were failing to pull in a bunch of coverage data,
and the error drawer showed:

  [path_to_gcda_file]: cannot open data file

I believe this happens when the data in the gcda/gcno doesn't match the
current source files on disk.  Didn't we used to get a better error message
out of gcov?  Are we missing part of the message, or should we flag when we
get errors and add an info follow up suggesting they clean out the coverage
data and rerun to suggest a solution?

What steps will reproduce the problem?
1. Go to Prefs: Test Files
2. Click "+"

What is the expected output? What do you see instead?
I hoped to see some visual indication that the program had done something.
What I saw instead was that the screen was the same as before I clicked.


What version of the product are you using? On what operating system?
4.0.1


Please provide any additional information below.
Instead of adding a blank line, add a line that says, "<new pattern>" or
"<replace me>". Selecting it would also be nice.

Opening the attached file with CoverStory will lead to a crash. Log is attached.

if you hit reload while data is still loading, it dumps what it has, but
ends up w/ two threads loading data, so the coverage data you get is from
both sets of loads, not really want the user wanted.

Overall coverage number is inflated because the unittests themselves end up
in the display (and hence totals).  Like the sdk filter, it would be nice
to have a filter to remove all unittest files.

What steps will reproduce the problem?
1. With either XCode 3.2.6 or XCode 4.2.1 turn on GCov results and build a 
large project with over 1000 files (I had 1233)
2. Confirm .gcno and .gcda files are produced during compile and execution 
respectively
3. Launch CoverStory 4.2.0 
4. Open folder location of .gcno and .gcda files (<build output 
dir>Objects-normal/x86_64/)
-> it will take 4-6 minutes or so with this many files but it does complete and 
you see the overall coverage number
5. File -> Export HTML
6. Choose a directory that you can write to (Desktop)

Expected: HTML files are written just like they are with smaller programs

Actual: CoverStory goes to 100% CPU for a second but not files written

What is the expected output? What do you see instead?
The command doesn't complete and no HTML is produced.

What version of the product are you using? On what operating system?
CoverStory 4.2.0 on Mac OS X 10.6.8 with XCode 3.2.6 (Mac Pro 5,1 with 16GB RAM)
and
CoverStory 4.2.0 on Mac OS X 10.7.3 with XCode 4.2.1 (Mac Pro 5,1 with 16GB RAM)

Please provide any additional information below.

The workaround is to look at individual files coverage but our project would 
like an easy way to export the whole coverage data set and archive that without 
having to just do screenshots to compare runs over time. Export to HTML works 
for smaller data sets.

Is there a way I can get the source and debug exactly where this is happening? 
What version of XCode did you use to build Coverstory 4.2.0? Are there build 
steps that I can try on my end?

I'm using the google toolbox for Mac project to write iPhone-Unit-Tests.
If I want to use CoverStory to open gcda/gcnd-files which were generated
while building the test target CoverStory crashes with the following error
while opening some of the files:

06.08.08 08:59:48 CoverStory[703] An uncaught exception was raised
06.08.08 08:59:48 CoverStory[703] *** -[NSConcreteScanner
setScanLocation:]: Range or index out of bounds 
06.08.08 08:59:48 CoverStory[703] *** Terminating app due to uncaught
exception 'NSRangeException', reason: '*** -[NSConcreteScanner
setScanLocation:]: Range or index out of bounds' 
06.08.08 08:59:48 CoverStory[703] Stack: (
    2498842955,
    2486731003,
    2498842411,
    2498842474,
    2500518256,
    23680,
    22874,
    16112,
    13585,
    2500009757,
    2500008644,
    2483291893,
    2483291570
) 

I suppose that happens for all files I added to the test target althougth
they are not necessary for the tests.

I am able to generate .gcda  files. But files are not able to generte the 
coverage reports giving below errors in coverstory:

Scanning for coverage data in 
'/Users/krishna/Library/Developer/Xcode/DerivedData/Krish-fdiyokrobaqdnnegnllxqy
dmbpzb/Build/Intermediates/KrishAppKit.build/Debug/KrishAppKitTests.build/Object
s-normal/x86_64'
Found 7 gcda files to process.
xargs: (null): No such file or directory
/Users/krishna/Library/Developer/Xcode/DerivedData/Krish-fdiyokrobaqdnnegnllx
qydmbpzb/Build/Intermediates/KrishAppKit.build/Debug/KrishAppKitTests.build/Obje
cts-normal/x86_64:failed to process files: (
    "KLog.gcda",
    "KNetworkController.gcda",
    "KNetworkControllerTests.gcda",
    "KSystemLogger.gcda",
    "KSystemLoggerTests.gcda",
    "KrishAppKitTests.gcda",
    "Reachability.gcda"
)

No coverage data read.
It took 0:00 to process the data.


What is the expected output? What do you see instead?
It must show the coverage report.

What version of the product are you using? On what operating system?
Xcode 4.5 & MAC OS 10.8.2 & this is the MAC application not ios.

make the percentage at the top of the file list clickable, and have it own a 
sheet w/ the summary 
info (like textwrangers char/word/line count)

What steps will reproduce the problem?
1. Launch CoverStory
2. Open some gcda/gcno document or folder with such files
3. Close opened window (independently of finished loading or not)
4. Using File->Open Recent try to open previous document (or folder)

What is the expected output? What do you see instead?
The open for selected document must be opened, instead nothing happens

What version of the product are you using? On what operating system?
CoverStory 4.4.1. Mac OS X 10.8.4

Please provide any additional information below.
Patch with fix is attached.

Actually this is a feature proposal:
Added column named "Left" to the table, presenting number of left uncovered 
lines in corresponding file. This gives possibility to sort by this parameter 
and thus to find most critical modules to UT

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?


Please provide any additional information below.
Patch with the proposed feature is attached

What steps will reproduce the problem?
1. I am trying to open folder containing .gcda and .cgno files
2. My project generating 241 gcda and gcno files. when I am trying to open the 
folder its continuously
showing spinning action saying "Found 241 gcda files to process.". I have left 
it for 30 min.
3. It is working fine for 160 files or less in my system (iMac). In other 
system (Mac Book Pro) it is working fine for 50 or less files.

What is the expected output? What do you see instead?
I expect to open all files. 

What version of the product are you using? On what operating system?
I am using Mac OS X 10.7.4 , Xcode 4.6 and CoverStory 4.3.0

Please provide any additional information below.
I have attached a screenshot of the issue please have a look.

What steps will reproduce the problem?
1. Create a folder with complex sub-hierarchy and many coverage files inside
2. Make sure that source for such project is unavailable
3. Add that folder to CoverStory

What is the expected output? What do you see instead?
The UI should remain responsible during and after files loading, but instead 
the UI becomes unresponsive when errors start heavily logging in drawer

What version of the product are you using? On what operating system?
CoverStory 4.4.1. Mac OS X 10.8.4

Please provide any additional information below.
patch with fix is attached

Has anyone got this to work with Snow Leopard and the iPhone SDK?  (3.2.x)

Sometimes it will build all the way through.  Tweak a setting, then you're 
toast.

Summary
The gutter currently displays red lines for unexecuted lines. Sometimes it's 
useful to display executed lines instead, as when tracking down a bug (rather 
than doing unit tests).

Attached is a patch (which includes the patch for #37, sorry) which adds this 
to the preferences, etc. it also ties the gutter color to the existing color 
prefs.

[deleted issue]

Hey guys.  I really appreciate the help and patience.  As you can tell, I 
temporarily abandoned trying to learn/use Coverstory.  But thankfully it 
was a rainy day that kept me inside and I decided to learn how to figure 
this out.

I think I made significant progress.

Here are some notes of what I did and what I'm still trying to overcome.

First of all...my projects...I like to isolate business logic/rules in a 
separate library.  So a ton of my code is in a static library project.  
Well, initially when I would link to -lgcov, it was throwing an error.  So 
luckily I found in a forum that I had to add /usr/lib/gcc/powerpc-apple-
darwin8/4.0.0 to the target's Library Search Path.  Naturally, I don't have 
this directory...so I downloaded that TigerGcov file and I pointed to that 
location.

Second, I have no idea what happened here but my RunIPhoneUnitTest.sh file 
was only like 8 or 9 lines.  Checking the file on google-toolbox-for-mac it 
is significantly different.  So I downloaded that file and updated it.  

As for the apple script.  When I run the script for it to enable code 
coverage...it works fine but it doesn't set the linker flag.  I have to go 
into each target and do that manually.  Speaking of individual targets....I 
can only get this to work if I run that apple script on every target.  Is 
that the way it's supposed to be?

After I build and debug the program...the files are finally created!  
However, I have to open each individual file one by one.  Whether I'm using 
the plug-in or just opening cover story directly....I have to open the gdca 
files individually.  I can see this being a nuisance in the future.

In my target with the unit tests, I have to use GCC 4.0.  And my static 
library, I can use either 4.2 or 4.0.  When I look at the files in 
Coverstory..I still get the 400A, prefer 402 messages.  Since I downloaded 
Tiger lgcov....is there a "newer version"?  BTW, I need to get the newer 
version of the plug-in.  Right now, I have 10.0.3 I think it is.

So aside from that...I finally look like I'm on the pace to make decent 
software that was tested correctly.  My outstanding issues are:

1.  Do I need to execute the apple script against every target?  (For 
example, my first iPhone app.  There are 4 targets.  The UI, the business 
library, Unit Test, Other Unit Tests)   
2.  How do I eradicate the 4.0 error/warning.  I'm assuming I need to 
be using 4.2 since that's the latest.
3.  How do I make Coverstory open all gcda files instead of each one 
individually.  (I tried navigating to the build directory or the parent 
directory with all the files, yet it still gives me an error message saying 
"The document "build" could not be opened.  CoverStory cannot open files of 
this type"

I really appreciate everyone's time and help in this.

We need more help. Currently it's just a place-holder.

What steps will reproduce the problem?
1. Create a simple class with a single propery that uses @synthesize to get+set 
it's value
2. Make a test that creates the class, but does not set the property.
3. Run the test and capture coverage

What is the expected output? What do you see instead?
I expect it to complain that the @synthesized property is not covered. Instead, 
it complains about 
the @end line on the class.

What version of the product are you using? On what operating system?
CoverStory: version 3.0.1
OS: 10.5.6
Xcode: 3.1.2
iPhone SDK: 2.2

Please provide any additional information below.
Test case attached.

I'd like to use your reports in my CI workflow as I find "gcovr" results 
confusing.

However, CoverStory has only GUI. 
Using automator script does not scale really good and may be not reliable 
enough.

Please add CLI to your application. In a perfect case it should automatically 
detect coverage files location.
https://software.sandia.gov/trac/fast/wiki/gcovr

we've got a growing number of hidden prefs that should probably get real ui
in the prefs window (issue already opened for the sdks/tests filters), but
i just added the common path prefix hiding.

Hi guys - I'm really enjoying cover story as I continue to get my feet wet with 
code coverage and 
unit tests.

One of the patterns I've fallen into is to use Cover Story on a single file, 
scanning down until I 
find some big red chunk of uncovered code. I'll then go write tests/fix 
sources, and come back to 
cover story for an update. 

I want to see the red turn black.

When I reload the data in cover story, it inevitably scrolls to the top of the 
document, or maybe 
it's "to the first red chunk."

I think it would be a nicer UE if you could try to keep the scroll offset the 
same when reloading, 
so that we can have the satisfaction of seeing that red turn black, and then 
proceed with scrolling 
down the file to other chunks of red.

Thanks for providing this tool.

Daniel

If you have a project that uses gcc4.2, you get a bunch of errors like this:

version '402*', prefer '400A'

We should detect this and switch which gcov we use instead of needing the user 
to hit the hidden 
default.

CoverStory.4.2.0 does load, CoverStory.4.3.0 does not load on 10.5.x 
(CoverStory.4.3.0 should be recompiled to support 10.5.x)

When one lets CoverStory analyze a folder containing more than about 40 gcda 
files which have 
been created by gcc 4.2, CoveStory deadlocks in the process.
I traced this down to a bug in GTMScriptRunner class:
When analyzing gcc 4.2 files, gcov produces error messages of the kind

version '402*', prefer '400A'

which quickly fill the standardError pipe. GTMScriptRunner only drains the 
standard error pipe after 
it has waited for the standardOutput to close. This is a deadlock situation.
I also filed this as a bug in the google toolbox project:
http://code.google.com/p/google-toolbox-for-mac/issues/detail?id=25

I found and fixed two memory leaks in CoverStoryDocument. Path file included.

Regards,

-- Tito

When you run gcov over category Objective-C files (e.g. NSString+Catname.m) the 
gcda files produced will have a + sign in their name.

This is fine for most purposes except for hrefs inside the CoverStory generated 
HTML files. If I serve these as a TeamCity coverage report artefact, these 
hrefs appear as broken links.

URL encoding these hrefs would help immensely. If I've interpreted the code 
correctly, the "problematic" line is 1239 in CoverStoryDocument.m. Using 
something like 

    [link stringByAddingPercentEscapesUsingEncoding: NSUTF8StringEncoding]

instead of

    link

as the second argument to [filesHtml appendFormat: ] should probably do the 
trick.

What steps will reproduce the problem?
1. Generate .gcda files for a project that contains .m files with categories 
named in the format Class+Category.m
2. Open the files in CoverStory and export it to HTML
3. Resulting HTML files will have href links to this report as <a 
href='Class+Category.m.html'>, which will break on some web service since + 
will be replaced by a space.

What is the expected output? What do you see instead?
<a href='Class%2BCategory.m.html'> would be safer for most web servers.

What version of the product are you using? On what operating system?
Version 4.3.0 on Mac OS X - 10.7 Lion


Please provide any additional information below.
N/A

What steps will reproduce the problem?
1. Just open a folder with deep hierarchy and many gcda/gcno of some complex 
project  (having many sub projects/targets)
2.
3.

What is the expected output? What do you see instead?
The progress indicator should always stop

What version of the product are you using? On what operating system?
CoverStory 4.4.1, Mac OS X 10.8.4

Please provide any additional information below.
Patch with fix is attached.

What steps will reproduce the problem?
1. Look at a file (other than the first one) and scroll down to something
interesting
2. Change the file in Xcode and rerun the program (or tests)
3. Back in CoverStory, click "Reload"

What is the expected output? What do you see instead?
What I'd like to see is the same file I was looking at before, scrolled to
the same place (or some reasonable facsimile).

What I see instead is the first file in the list is displayed, scrolled to
the top.


What version of the product are you using? On what operating system?
4.0.1

Please provide any additional information below.

If you call gcov with "gcov -b -c", it provides enough information that you
can measure both branch and condition coverage. It would be really nice if
CoverStory handled them also.

(If you do work on this, the current versions of gcov and gcc have a couple
of bugs related to handling @throw and @try / @catch blocks.)

As an example of the value, when I got my target program to 100% feasible
line coverage, I still had only about 90% branch coverage and about 85%
condition coverage. In improving those, I found two corner case bugs. Not
high impact bugs, but still they would have bothered me.

I'm trying so set up code coverage on my Xcode project i get this error when i 
open my test build directory with coverstory :

Objects-normal/i386/CTidy.gcno:cannot open graph file

Here is a snapshot of the complete log :

http://i.stack.imgur.com/Ppnty.png

To reproduce, just setup a standard GCov build config in Xcode and open the 
output files in CoverStory. The coverage is always 0%. 

As explained here : 

http://stackoverflow.com/questions/1385568/why-doesnt-gcov-report-any-lines-bein
g-covered-by-my-unit-tests 

it may be related to the version of gcc, since gcc4.0 instead of 4.2 produce a 
sensible output. The problem, is that when developing with iOS 4.2, UIKit uses 
blocks (among other things), and gcc4.0 doesn't work with them. Hence gcc4.2 is 
required. 

It is a re-opening of #issue28 since it has been set as invalid because of its 
bad description.

the show/hide of sdks, test files, complexity should really only affect the
front window.

the filter list for sdks, test files, hiding of common prefixes are all
truly prefs that should go in the prefs window and affect all windows.

Coverstory should include a "refresh" which will rescan the coverage files in 
the current window.  
Since most users of coverstory will do so in order to acheive line coverage on 
a project, it is 
reasonable to expect that they will be modifying the covered code in order to 
reach the desired 
coverage.  It is annoying to such developers to have to close the window and 
open it again in order 
to get new information.

Cover Story consistently crashes for me (NSScanner raises an exception)
when opening files. Adding this change fixes it:

Index: CoverStoryCoverageData.m
===================================================================
--- CoverStoryCoverageData.m    (revision 89)
+++ CoverStoryCoverageData.m    (working copy)
@@ -152,6 +152,8 @@
       while (![scanner isAtEnd]) {
         NSString *segment;
         BOOL goodScan = [scanner scanUpToString:@":" intoString:&segment];
+        if ([scanner isAtEnd])
+          break;
         [scanner setScanLocation:[scanner scanLocation] + 1];
         SInt32 hitCount = 0;
         if (goodScan) {

What steps will reproduce the problem?
1. Setup project in Xcode 4.5 with LLVM Apple compiler
2. Set project up for code coverage
3. Point CoverStory using the Open option to the folder that has code coverage 
files. All the (.o, .d, .dia, .gcda, .gdno) files are under this directory. 
There are no sub folders.

What is the expected output? What do you see instead?
CoverStory should provide an overview of the whole project. Right now it just 
spins endlessly and doesn't show anything.

PS. If I try to open an individual .gcda files it would give code coverage for 
that. But would give a warning: gcno:version '404' perfer '402'.

What version of the product are you using? On what operating system?
CoverStory:4.3
Mac OS 10.7.4

Please provide any additional information below.

What steps will reproduce the problem?
1. build and run tests, quit simulator
2. load gcno & gcda files

What is the expected output? What do you see instead?
correct results. instead, i get 0%. however, the gcda files are generated. The 
following error appears in the messages drawer

    x Objects-normal/i386/[blah].gcno:version '404*', prefer '402*'

What version of the product are you using? On what operating system?
Coverstory 4.3.0
Mountain Lion 10.8.1
Xcode 4.5 DP4

Please provide any additional information below.

What steps will reproduce the problem?
1. Try to open multiple .gcda files
2. I can't find any way to get all the files open in one CoverStory window,
which is really annoying.  I want to be able to browse the code coverage
figures for my whole project.

What is the expected output? What do you see instead?
I expect all the files in one window, like that shown on the screenshot
showing how to use CoverStory!

What version of the product are you using? On what operating system?
v4.0.1 on Mac OS X

Please provide any additional information below.

What steps will reproduce the problem?
1. Set up and build Google Unit Test for a source file (e.g., foo.cpp and 
fooTest.cpp)
2. Run the test in XCode 4.6 using C++ LLVM 4.2 compiler with gcov output set 
up.

What is the expected output? What do you see instead?

CoverStory should show the lines of code in foo.cpp which were executed by 
fooTest.cpp.  In the foo.gcda window, each line should display the number of 
times it was executed in the left gutter of the source text pane

Actual output shows a single line (sometimes inside a comment) and the coverage 
is given as "Executed 100% of 1 lines (1 executed, 1 executable, 4313 total 
lines".  The code in the window is grey (unexecuted) except for a single line 
which shows as executed 1 time in the left gutter of the pane.

Number of lines in file is given correctly, executable and executed line counts 
are incorrect.  In the 4313 line example file, there should be 1609 executed 
out of 1610 lines total.

What version of the product are you using? On what operating system?

CoverStory 4.3.0 (no updates available) on Mac OS 10.8.2.

Please provide any additional information below.

Note that the fooTest.gcda file was accurately interpreted, showing 2557 of 
2570 lines being executed, gutter contains expected numbers of executions of 
the different lines and only comment lines are displayed in grey.

The foo.gcda file built by XCode 4.5.2 and C++ LLVM 4.1 compiler was correctly 
interpreted and displayed.  A brief examination of a foo.gcda file shows that 
the 4.2 output differs from the 4.1 output by having additional header data and 
possibly other changes.  This appears to confuse CoverStory but does not cause 
an error message.  The message drawer has five information items but no errors 
or warnings.

errors like the graph data mismatch of source should be trapped and we
should pop a sheet or add an info message to the log saying what has to be
done to fix it (clean coverage data and rebuild/run)

When double clicking a line in the CoverStoryDocument gutter, a crash occurs. 
This is due to the fact that the selector 'openSelectedSource' doesn't exist. 
Instead, it's 'openSelectedSource:' (expect a parameter).

I have fixed it, but instead of submitting the patch file, I include a 
screenshot. The reason is that Xcode 4.3 has polluted the file with additional 
internal changes, so it's difficult to see where I made the change.

The screenshot make it pretty clear.

Regards,

-- Tito

if you have start loading two different build output dirs at the same time,
it's not uncommon to get errors as the temp folders we use can be common
since we pick names from w/in the build folder and xcode uses common names
between projects (ppc, i386, etc.)

What steps will reproduce the problem?
1. Open a folder with gcda/gcno files
2. Check switchers in toolbar
3.

What is the expected output? What do you see instead?
the switchers should work independently of each others, but they depend on SDK 
switcher

What version of the product are you using? On what operating system?
CoverStory 4.4.1. Mac OS X 10.8.4

Please provide any additional information below.
patch with fix is attached

What steps will reproduce the problem?
1. Run coverstory app.  Click open, navigate to folder containing *.gcda files
2. From the plug-in within Xcode, choose build - show code coverage for - 
target/project.
3.

What is the expected output? What do you see instead?
An error/alert message saying The document “Objects-normal” could not be 
opened. CoverStory 
cannot open files of this type.  Or The document “build” could not be 
opened. CoverStory cannot 
open files of this type. (The tree isn't being walked)

What version of the product are you using? On what operating system?
Coverstory 4.0.1, Xcode plug-in 10.0.5, Snow Leopard 10.6.3


Please provide any additional information below.

Has anyone got this feature to work until Mac OS 10.6.3?

What steps will reproduce the problem?
1. Go to Preferences, Test Files
2. Enter a pattern that does _not_ start with a "*" or the full path name.
3. Go back to main window and click "Hide Test Files"

What is the expected output? What do you see instead?
I'd like to not see my test files. Instead, I do see them. (See below)


What version of the product are you using? On what operating system?
4.0.1. MacOS 10.5.8.


Please provide any additional information below.

This is only an issue when the file names to be filtered out do not end
with the marker. I named my tests as, e.g. TestWUerror.m. At first, I
entered the pattern as "Test*.m". When I entered the pattern as
"*/Test*.m", things worked the way I expected them to. But I had to use the
debugger to figure this out. I didn't see anything in the program or the
wiki that helped me.