chhsiao90 / gviewer Goto Github PK

Introduce controller for following purpose

• More cleaner
• Release API

Follow the rule from Google Python Style Guide

1. Support text markup on detail and summary
2. Provide some pretty palette

User could bind their custom keys for some actions, but when it duplicate with gviewer built-in keys, it would be ignored.
Need raise Error for this problem

Somebody need, somebody don't need.
So I planned to add a config argument to enable/disable auto scroll down when new message received and provide the functionality to auto scroll down.

Reference mike820324/microProxy#156

That gviewer seams to eat many exception and will be hard to debug if program had exception.
So need exception handling on some situation:

• display summary
• display detail

Maybe had an exception view for record these error is a good practice

Need support pypi

Make sure that gviewer could integrate with pygments and provide sample code.

Currently, when notification happen, it need focus on the notification bar to make sure that the message would be cleanup correctly.
But it cause some user experience problem, that their next key(action) will not do anything but just clean up the notification bar and in-focus it.
I think there might be better solution for it!

Need encode with specific encoding(utf8) when write to file

Use function to implement something like to_detail_groups is more simple with implement abstract class DetailDisplayer.

Original MicroProxy issue: mike820324/microProxy#154
Just a nice to have feature that pressing some key will scroll to the top/bottom of the page.
For instance,

• gg -> to the end of the page
• G -> to the top of the page.

That when using GViewer with searching, it's hard to know that is in search mode or not.
That cause exit GViewer by accident.

I think it should display current search keyword at the bottom.

The Error:

Defaulting to user installation because normal site-packages is not writeable
Collecting gviewer
  Using cached gviewer-3.0.6.tar.gz (22 kB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error
  
  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [8 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/tmp/pip-install-mhbbda84/gviewer_59bd9eeb76e54fe4a0253fdd5ded538d/setup.py", line 10, in <module>
          with open(os.path.join(here, 'README.md'), encoding='utf-8') as f:
        File "/usr/lib/python3.10/codecs.py", line 905, in open
          file = builtins.open(filename, mode, buffering)
      FileNotFoundError: [Errno 2] No such file or directory: '/tmp/pip-install-mhbbda84/gviewer_59bd9eeb76e54fe4a0253fdd5ded538d/README.md'
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

Quit without confirmation will bring some bad user experience.
When user try quit from gviewer, it would open a user prompt to ask user really want to quit.

Provide multiple views in a GViewer.

It seems that the current line number will not update correctly when auto scroll down

The [current/max] should be display on footer

There are bugs when switching summary view

1. The [current number/max number] will update when each view update, and the number is not as our expected
2. When switch to another summary view, the [current number/max number] didn't update immediately.

Currently, footer only show [1/5] for the selection on summary view
It would be good to also display XXX[1/5] for which view is display.

Because that public method from GVIewer had some major modifiaction (shorter, and cleaner).
Need update README.md for new interface