chickenprop / cloggle Goto Github PK

Now that you have contributions from more than person, you might want to choose a license for cloggle. :-)

I'd like to propose a couple of suggestions for making cloggle more idiomatic. I'm new to Clojure, but have been a Common Lisp user for a while now, so I still think my suggestions apply to Clojure.

Wrapper macro names should begin with "with-". (For examples just look at all the API functions that have a "with-" prefix, like with-in-str, with-local-vars, etc.)

Specifically, I think ctx should be either with-ctx, with-context, or something similar.

I suggest doing the same with your beg-end macro: with-primitive is the name used by cl-opengl, is probably my first choice.

Similarly, it would be nice to have a with-pushed-matrix macro which handles calling glPushMatrix and glPopMatrix.

My other general suggestion is that you name global variables with asterisks (e.g. *ns* in the Clojure API). So opengl-context should be *opengl-context*, etc.

Hope this helps. I've learned a lot from your source code so far and look forward to working with it more :-)

Let me know if you'd like me to provide a patch with these changes.

Thanks.