chlumsky / artery-font-format Goto Github PK

Hi,

I am trying to read the example font as a test for the library, but artery_font::read returns false. Am I doing something wrong or is the file outdated ?

#include <cstdio>
#include <cstdlib>
#include <iostream>

#include <std-artery-font.h>
#include <stdio-serialization.h>

int main() {
  FILE *const font_file = fopen("example.arfont", "r");
  if (font_file == nullptr) {
    std::cerr << "couldn't open font file" << std::endl;
    return EXIT_FAILURE;
  }

  artery_font::StdArteryFont<float> font;
  if (!artery_font::read(font, font_file)) {
    std::cerr << "couldn't read artery font" << std::endl;
    return EXIT_FAILURE;
  }

  return fclose(font_file) == 0;
}

the crc32.h never does the final ^0xFFFFFFFF to checksum when all the data has been serialized.

I'd like to use the code in this repository, as well as a repository that pulls this one as a submodule. I am concerned about the legal implications, however, of using a repository with no license. After some investigating, I've found that there's very little I can count on when no license is present. Would you consider adding a license (I can submit a pull request to do so)? I appreciate your use of the permissive MIT license in your other projects, do you have anything against using it for this code as well?

example.arfont from version 1.0.1 works fine.
when i generate arfont with msdf-atlas-gen.exe arfonts always fail to load.
im not sure if arfont format is designed to be widely used or its just internal thing?

using png + json given by msdf-atlas-gen.exe is the only other option to get font data?

Hi,

as an effort to upload a package for this library into conan center, I noticed from the code that the version of this lib is 1.0, but there is no tag. This is not a big problem since there is a procedure for libraries without official versions, but I thought that it would be nice to have the tag for this purpose as long as others.

N.B: since it is a header-only library, the integration to conan packaging won't require any file addition in this repo.