optimize: true breaks es6 compatibility about bankai

[rahatarmanahmed]

The workaround for this, as @yoshuawuyts says, is to have duplicate yoyoify and sheetify transforms before babelify. Not ideal but it seems to work.

const jsOpts = {
  js: {
    transform: [
      'envify',
      'sheetify/transform',
      'yo-yoify',
      ['babelify', { presets: ['latest'] }]
    ]
  },
  optimize: true
}
const clientPath = path.join(__dirname, '../client/app.js')
client = bankai(clientPath, jsOpts)

[MattMcFarland]

I am happy to send PR but I dont know what strategy we should take for fixing this.. thoughts are welcome :)

[yoshuawuyts]

so which of these lines is failng? What happens if you disable one of them?

…

On Tue, Jan 17, 2017 at 4:42 PM Matt McFarland ***@***.***> wrote: I am happy to send PR but I dont know what strategy we should take for fixing this.. thoughts are welcome :) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#117 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWlenmZNdX0Al18Q14XV3F8YQdkupJ6ks5rTOFogaJpZM4LlC9h> .

[MattMcFarland]

Both fail, when disabling one or the other uglifyjs does not like template tags nor does it like arrow functions.

[MattMcFarland]

I think one way to fix this would be to transpile before it is sent to uglifyjs. However, if you transpile first then call yoyoify it blows up.

The problem is that yoyoify has to be called before you transpile and you have to transpile before you run uglifyjs - I havent confirmed this but that is the only thing that makes logical sense to me atm.

[yoshuawuyts]

Yeah I think what you're saying makes sense. I think you can circumvent this by including es2020 + yo-yoify in your package JSON though, in the right order

…

On Sat, Jan 21, 2017, 23:09 Matt McFarland ***@***.***> wrote: I think one way to fix this would be to transpile before it is sent to uglifyjs. However, if you transpile first then call yoyoify it blows up. The problem is that yoyoify has to be called before you transpile and you have to transpile before you run uglifyjs - I havent confirmed this but that is the only thing that makes logical sense to me atm. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#117 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWlehzDlz-1Yyqq5qUiE063YbhGUtLPks5rUoIRgaJpZM4LlC9h> .

[delvedor]

Hi guys, same problem here!
Solved in this way:

"script": {
"build:browser": "bankai build browser/index.js --optimize --electron build-browser/"
}
"browserify": {
  "transform": [
    "unassertify",
    "yo-yoify",
    "es2020"
  ]
}

[yoshuawuyts]

You can now do --uglify false and it should no longer crash, can just pull in your own uglify (: Given the lack of activity I think this issue has been resolved. Feel free to reopen if it hasn't been. Cheers!