chr-1x / twc Goto Github PK

char* DeclName = ArgCount >= 3 ? ArgValues[3] : "code/twitter_api.h";
char* ImplName = ArgCount >= 4 ? ArgValues[4] : "code/twitter_api.c";

in codegen.c should be >= 4, >= 5

There are three things using C99 features:

• twc_option and twc_buffer construction macros
• exactly one other macro construction somewhere in twitter.c
• declare-anywhere used here and there

None of these are critical, and use of the former needs to be scoped down a lot anyway for ease of language binding. C89 compat is a reasonable target and likely opens up path for compiling on less recent compilers (e.g. older versions of MSVC)

Only reproing on windows right now, but may be due to a shared bug on all platforms

In twitter.c, you should #include <alloca.h> for alloca. I get undefined references to alloca without this when trying to build my program with your library.

└──> dmd -debug -Jres/ blog.d libtwc.a -L-lcurl
libtwc.a(twitter.o): In function 'twc_GenerateOAuthSignature':
/home/mio/scripts/blog/bin/twc/code/twitter.c:700: undefined reference to `alloca'

ketmar tells me this is because of a gcc specific hack that transforms alloca into __builtin_alloca which gets inlined.

Here is a quote from man 3 alloca

Notes on the GNU version
Normally, gcc(1) translates calls to alloca() with inlined code. This is not done when either the -ansi,
-std=c89, -std=c99, or the -std=c11 option is given and the header <alloca.h> is not included. Otherwise,
(without an -ansi or -std=c* option) the glibc version of <stdlib.h> includes <alloca.h> and that contains the
lines:
#ifdef GNUC
#define alloca(size) __builtin_alloca (size)
#endif
with messy consequences if one has a private version of this function.
The fact that the code is inlined means that it is impossible to take the address of this function, or to
change its behavior by linking with a different library.

comparing to the wrong size
it should be SourceIndex < Path.Size;

Can you confirm this issue on your end?
My test code is as follows:

        auto tweet = "looks like @chronaldragon's twc is working :) (this tweet sent from a #dlang script)";
        enforce(twc_statuses_updatee_params.init.MediaIds == null);
        twc_call_result x = twc_Statuses_Update(&twitter, twc_ToString(tweet.toStringz),
                twc_statuses_updatee_params.init);
        writefln("%s", x.ErrorStr.Ptr[0..x.ErrorStr.Size]);

The response:

{"errors":[{"code":44,"message":"media_ids parameter is invalid."}]}

ReadFileAndNullTerminate in codegen.c calls fopen, but never fclose

../code/twitter.c(5): fatal error C1083: Cannot open include file: 'alloca.h': No such file or directory

'cp' is not recognized as an internal or external command, operable program or batch file.

you might have some linux tools in your path. you can use copy instead.