chrissheppard41 / ship_display_tool Goto Github PK

Encountered a kill throwing Division by zero errors with the following stacktrace:
WARNING [2] Division by zero
Error on line 1242 in file /www/htdocs//_//killboard/mods/ship_display_tool/init.php
PHP 5.2.12-nmm4 (Linux), EDK 4.2.1.0 (Kronos 1.0)
File: /www/htdocs/__/killboard/mods/ship_display_tool/init.php, line: 1242, class: EDKError, function: handler
File: /www/htdocs/__/killboard/mods/ship_display_tool/init.php, line: 635, class: FittingTools, function: remoteRepStats
File: /www/htdocs/__/killboard/mods/ship_display_tool/init.php, line: 351, class: FittingTools, function: getExtraStats
File: /www/htdocs/__/killboard/common/includes/class.pageassembly.php, line: 80, function: call_user_func_array
File: /www/htdocs/__/killboard/common/includes/class.pageassembly.php, line: 44, class: pageAssembly, function: call
File: /www/htdocs/__/killboard/common/kill_detail.php, line: 1620, class: pageAssembly, function: assemble
File: /www/htdocs/__/killboard/common/index.php, line: 303, function: include
File: /www/htdocs/_**/killboard/index.php, line: 27, function: include

Link to kill causing this problem: http://public-crest.eveonline.com/killmails/39436269/be5b4f7a6e8b98c3438c2e48f1e849da4695c899/

When displaying the loss of a ship that had fitted ships in its ship maintenance bay, the modules fitted on the ships in the SMA get displayed as fitted on the main ship.

CREST link for an affected kill: http://public-crest.eveonline.com/killmails/39366844/7f1767445948b24f01dd72745f52f1ec7176ad56/

Screenshot:

There has been a bug in class.itemlist.php since the release of EDK 4.2, causing items in the "None" bay (Inventory Flag 0) to be displayed with their quantity doubled.
This bug has been fixed with commit evekb/evedev-kb@2752cd4 , but since the mod brings its own version of the library, this bug has been inherited and needs to be fixed there as well

The ship display tool creates an error when the new
"Capsule - Genolution 'Auroral' 197-variant" is viewed. Problem is with the single quotes in the item name.

There is already a fix posted in EDK forums. It would be nice to have this fix included in a new release of this mod.
See this forum thread: http://www.evekb.org/forum/viewtopic.php?f=505&t=17295&p=47240#p47213

I'm unsure if this is a problem due to my configuration or something you need to fix in the code?

Getting this at the top of the screen when opening a kill:

DEPRECATED [8192] Non-static method Calculations::calculateMass() should not be called statically, assuming $this from incompatible context
Error on line 514 in file /var/www/killboard/mods/ship_display_tool/Libs/Fitting.class.php
PHP 5.6.16-2+deb.sury.org~trusty+1 (Linux), EDK 4.2.17.0 (Frostline 1.0)
File: /var/www/killboard/mods/ship_display_tool/Libs/Fitting.class.php, line: 514, class: EDKError, function: handler
File: /var/www/killboard/mods/ship_display_tool/init.php, line: 309, class: Fitting, function: getShipStats
File: /var/www/killboard/common/includes/class.pageassembly.php, line: 80, function: call_user_func_array
File: /var/www/killboard/common/includes/class.pageassembly.php, line: 44, class: pageAssembly, function: call
File: /var/www/killboard/common/kill_detail.php, line: 1731, class: pageAssembly, function: assemble
File: /var/www/killboard/common/index.php, line: 319, function: include
File: /var/www/killboard/index.php, line: 27, function: include

As of EDK 4.2.2.0 fetching from zKillboard is supported. This mod in version 3.5 doesn't know zKillboard as source, so the "source" field is blank.

Enhancement: Add zKillboard as valid source, perhaps even with a link to the exact kill (see here for how to identify a kill from zKillboard and parsing the source: https://github.com/evekb/evedev-kb/blob/4.0-dev/common/kill_detail.php#L1624)

If the mod finds Scan Resolution or Targeting Range Scripts fitted on a ship it automatically assumes there are also Sensor Boosters fitted. But if there only are Remote Sensor Boosters, it tries to access an array which is NULL, causining multiple warnings.

Add a check if there are really sensor boosters before trying to access the sensorbooster array in the Fitting class: https://github.com/chrissheppard41/ship_display_tool/blob/eve42/Libs/Fitting.class.php#L1441-L1448

Example kill CREST link: http://public-crest.eveonline.com/killmails/40926839/6ac342f9bcf6b9e6a2a05fdf6fe564fccce4243f/

Role Bonuses on ships (skillID = -1 in kb3_invtratis table) cause strange effects to be applied on the fitting stats.
Example: http://kb.bunkerhub.de/?a=kill_detail&kll_id=320826 (-4164.1 DPS).
When removing the role bonus from kb3_invtraits the DPS value returns to a more sane 973 DPS (missing the Role Bonus of 25% rate of fire).

If you look at this picture, you'll see the armor resists are completely wrong. Also the speed says 0 m/s

Link: https://shadowcartel.com/kb/index.php/kill_detail/259059/

As of EDK 4.2.2.0 a kill's CREST link is exposed when not using any kill_detail mods.
To maintain this functionality, expose a kill's CREST link (perhaps as link in the source field).
The Kill class has a method called getCrestUrl(), which returns either the kills CREST link or NULL, if the kill has not been posted via CREST (see https://github.com/evekb/evedev-kb/blob/4.0-dev/common/includes/class.kill.php#L1824).

Perhaps even add "CREST" as new source type for a kill.

If the first high slot of a ship does not have a weapon fitted using any ammo, all other fitted weapons using ammo are regarded as empty, even if they were not at the time of the kill.
Example: First high slot is a neutralizer, the missiles in the other launcher are disregarded (http://kb.bunkerhub.de/?a=kill_detail&kll_id=320900)

Example: First high slot is a launcer, ammo is recognized correctly (http://kb.bunkerhub.de/?a=kill_detail&kll_id=320829)

The problem seems to be in the Statistics::slot() method, which looks for ammo explicitly in the first High or medium power slot (disregarding charges for ancillary armor reppers in the low slots).

Attached are modifications to the init.php file that corrects these.

also see changes to the other files in this post....
http://www.evekb.org/forum/viewtopic.php?f=505&t=21873&p=50222#p50222

The PHP class in Libs/Statistics.class.php is actually called "Statis_i_tics" (without the _). It is correctly referenced as such throughout the Fitting class except in lines 1643 and 1645, where it is referenced as (correctly spelled) "Statistics" and thus is not found.

Fatal error: Class 'Statistics' not found in /www/htdocs/******/killboard/mods/ship_display_tool/Libs/Fitting.class.php on line 1645

Additionally, in line 1645 parameter 5 is an Integer, which cannot be passed as reference, as expected for that parameter by the method called, leading to:
Fatal error: Cannot pass parameter 5 by reference in /www/htdocs/******/killboard/mods/ship_display_tool/Libs/Fitting.class.php on line 1645

The logic for assigning missiles to launchers needs to be tweaked since the introduction of Rapid Heavy Missile Launchers. The Fitting::buildFit() method needs to be updated accordingly.
See https://github.com/evekb/evedev-kb/blob/4.0-dev/common/kill_detail.php#L1084-L1094 for a reference.