DISCONNECT master command does never timeout but retries indefinitely about pyxcp

[tttech-miori]

version 0.18.48

[tttech-miori]

Probably fixed here: #120
To be tested.

[tttech-miori]

This is fixed by #120
Thanks!

[christoph2]

Still not perfect -- I've tested the TIMEOUT case with my own cxcp project, there's no infinite loop anymore, but only a single SYNCH/DISCONNECT sequence.

Use-case: disconnect a slave which is potentially connected, just as a matter of fact to reset communication from a known state.

Not sure what potentially in this context should mean -- Or to put it another way: If there was a CONNECT before, the XCP slave must respond to DISCONNECT...

[tttech-miori]

Thank you for the reply.

Not sure what potentially in this context should mean -- Or to put it another way: If there was a CONNECT before, the XCP slave must respond to DISCONNECT...

True. At the same time, though, the action of disconnecting from a slave may be a preventive measure when you are probing system where its state is unknown i.e. I have my test-system / diagnostics tool and I issue a preventive "DISCONNECT" before attempting a new connection. In this situation, the slave is not going to answeron DISCONNECT.
"Potentially" referred to the possibility of having a slave that is still in connected state regardless of pyxcp (e.g. diagnostic tool or test system did not properly shutdown xcp)

Still not perfect -- I've tested the TIMEOUT case with my own cxcp project, there's no infinite loop anymore, but only a single SYNCH/DISCONNECT sequence.

Yes, actually you are right, I was just ok the software to not indefinitely block :-).
We should try that 2 times I guess based on the specification: DISCONNECT -> timeout t1 -> SYNCH -> timeout t1 -> timeout t1 -> DISCONNECT -> timeout t1 -> SYNCH -> timeout t1 -> timeout t1 -> END

NOTE: my slave runs the Vector XCP Basic implementation.

[christoph2]

OK, I see.

To support such scenarios, I've added a new config-option (Commit d0bc55d , Release 0.18.59)

• DISCONNECT_RESPONSE_OPTIONAL

TOML

DISCONNECT_RESPONSE_OPTIONAL = true 

JSON

"DISCONNECT_RESPONSE_OPTIONAL": true