christophsax / seasonalview Goto Github PK

Just found a bug in the view function. Fortunately it's simple to fix:
You use x as a parameter, but continue to use m below the story part. Your example work fine cause you use m and because of R's scoping m is found here.

https://github.com/christophsax/seasonalview/blob/master/R/viewer.R

 .GlobalEnv$.model.passed.to.shiny <- m
# should be 
 .GlobalEnv$.model.passed.to.shiny <- x

If you want to manually adjust the X-13 spec code...

Warning: Error in observerFunc: could not find function "import.spc2"
Stack trace (innermost first):
    57: observerFunc [/Library/Frameworks/R.framework/Versions/3.3/Resources/library/seasonalview/app/server.R#73]
     2: shiny::runApp
     1: view
ERROR: [on_request_read] connection reset by peer

x <- seas(AirPassengers, x11.seasonalma = "s3x5")
view(x)

an empty x11 = "" is added at the end of the R call box, leading to a
reevaluation of the call.

• R CMD check --as.cran
• Fix GHA
• Windbuilder, Macbuilder (change email address)
• Christoph to release

Including this for future reference.

The use of the ACE-editor (at least trough shinyAce) slows down website loading time by almost 4 sek on a slow Internet connection). Without some great benefit (e.g. autocompletion) that's not worth the pain.

The significance of the tests (e.g. test for no seasonality in final series) is sometimes not visible in the shiny interface. For example, summary(seas(x)) shows that H0 is rejected on the 1% level while in view() 1% is written in white color on a white ground, hence it is not visible.
Most likely, the problem is that the box around the "1%" has is of white color as well.

perhaps turn it off and got back to a scrollable area with fixed height