chrisui / babel-plugin-transform-react-binding Goto Github PK

Currently we just look at any class with a render method. Can't be this lazy in the real world! ;)

Hey,

the current version of the npm package (0.1.2) does not contain the compiled version (lib/index.js), meaning any require of this package will fail.

Could you publish a new version w/ the compiled source please?

Thanks!

As it says on the tin.

Where we have locally bound immutable identifiers being referenced inside arrow function bodys within a render method we could pull out into memoized-context-bound functions.

This is important for functional components where arrow functions are the preferred way to do a syntax-friendly form of partial application.

See example: https://gist.github.com/Chrisui/fc2e1b20c54c4c5befb7abad9c6a577f

Love this idea Chris! I'd like to fork and play with the code a bit, but am hesitant to do so without a LICENSE file. Would you be willing to add some sort of open source license? Thanks!

So in theory this plugin is great. We prevent the breaking of purity throughout our components transparently so should be able to avoid lots of re-renders without having to manually manage our bound functions and their references.

However, there is obviously some performance cost from doing the memoized bind so it would be good to have some very clear benchmarks which would demonstrate this and allow us to decide whether the optimisation is worth it or not.

These benchmarks should help:

• Determine whether this is even a viable solution (though the work done here should be what we do in our components anyway to keep purity)
• Determine location (per instance? per component?) of cache and size (dynamic? best default static?)
• Prevent performance regressions in future releases and allow people to test different caching algorithms