Body product term listed under anatomical material about dataharmonizer

[griffie]

Let me have a quick chat with Rhiannon. Not sure if she structured that to match the other fluids when seminal fluid was under anatomical material before (and I subsequently moved it), or whether that was from an ontology. Will let you know shortly....

[ivansg44]

This seems to be an issue with how we're bringing in data from our outside-versioned data.tsv file.

[ddooley]

people don't seem to be following the parent class/lable thing quite right. Fluid (seminal) has parent Fluid, but that's a term under the anatomical material. A term's position in hierarchy is about its parent, not what section it appears to be in spreadsheet.
I've fixed the seminal fluid one and will copy the vocab over...

[ddooley]

Sorry, "people" was a bit wide! This has only happened a few times. :)

[ivansg44]

@griffie @cmrn-rhi Is "Fluid (seminal)" supposed to be under body product? I noticed all the other fluids are under anatomical material.

[griffie]

"Body product" is a material that's meant to be secreted/excreted from the body. So whereas blood and saliva have jobs inside the body, feces, semen, urine, sweat, are meant to go out. So seminal fluid is categorized as a body product. Make sense?

[ivansg44]

Makes sense. Have you considered renaming "Fluid (seminal)" to just "semen", so that it matches the pattern used for the rest of body product's vocabulary (e.g., "urine", "sweat" and "breast milk")?

[cmrn-rhi]

There's no issue with renaming it. It was just structured that way to fit in with the other fluids when it was grouped with them.

…

On Thu, Jun 11, 2020 at 10:58 AM griffie ***@***.***> wrote: Let me have a quick chat with Rhiannon. Not sure if she structured that to match the other fluids when seminal fluid was under anatomical material before (and I subsequently moved it), or whether that was from an ontology. Will let you know shortly.... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#50 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALTQODQ6ZL6EPYQFGEGUIZTRWELMNANCNFSM4N2YAOXQ> .