GithubHelp home page GithubHelp logo

Comments (3)

tommyp1ckles avatar tommyp1ckles commented on July 4, 2024 1

Stumbled upon this, I did some work recently in Cilium that dealt with the issue of default batch sizes that is likely related.

There's been work done to significantly improve the batch lookup API, but it would be nice to start looking at maybe providing a iterator pattern that would satisfy the Go rangefunc experimental feature.

from ebpf.

lmb avatar lmb commented on July 4, 2024

I would love it if Map.Iterate transparently used batch lookups if possible. (Less of a fan of a new API, we might have to break compat when / if Go gets iterators.) The devil is in the details though:

  • How many keys and values do we fetch in one go? There is not really a number that is correct for all cases. I'd probably start with a heuristic of using a page of memory for keys and values each, something like os.Getpagesize() / Sizeof(T). Allow the user to override that somehow. MapIterator.Items or something like that?
  • How do we deal with differences in semantics? For example, right now concurrent iteration and delete is undefined behaviour. I don't expect that to change with batch lookup (can't get more undefined) but is there a difference in practice to the reset behaviour we get for single key lookups?

from ebpf.

lmb avatar lmb commented on July 4, 2024

I would love that. However, your work plus my recent experience with #1485 makes me think that the current API is basically unusable in a generic fashion. We don't know anything about the map in question except the max entries really. In the worst case, we could have a single bucket with max_entries in it. How would we deal with that? Fall back to regular iteration at some point?

from ebpf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.