Comments (3)
Originally posted by @ti-mo in #812 (comment)
[...] Build tags are a hard nack from me, and ldflags are quite cumbersome to specify.
We've also recently adopted envs in cilium/cilium
to gate test behaviours. All in all, I think it's the lesser evil, because they can be set ambiently and are easy to slap onto any command, as there might be arbitrary tools/scripts in between your shell and the actual test binaries reading the env.
I'd probably go with a single env here (like EBPF_TEST_IGNORE_KERNEL_VERSION
?) that basically trusts the verdict of our haveBPFXYZ()
functions and doesn't execute the kernel version check. We could add this kind of skip in testutils.CheckFeatureTest()
or testutils.checkKernelVersion()
, although the latter might cause more unintended side effects.
As long as the default doesn't change and we don't relax CI.
from ebpf.
@lmb I would like to work on this improvement.
I also feel testutils.CheckFeatureTest
is better place to make this change.
How about keeping EBPF_TEST_IGNORE_KERNEL_VERSION
as list of feature names ( snake cased + lowercase ) to ignore so that multiple features can be silenced.
eg: EBPF_TEST_IGNORE_KERNEL_VERSION="bpf_link_kprobe_multi,socket_filter"
.
from ebpf.
Hey, thanks for taking some time to work on this!
Changing CheckFeatureTest
sounds good to me, as does splitting on ,
. Why do you want to use the feature name though? I think it would be easier to compare against tb.Name()
, so that you could do EBPF_TEST_IGNORE_KERNEL_VERSION=TestHaveBatchAPI,TestHaveObjName
. That way you can just copy and paste from the go test
output if necessary.
from ebpf.
Related Issues (20)
- Add support for cgroup unix socket address hooks HOT 4
- CI: TestMapBatch/Hash is flaky (arm64?) HOT 2
- dae can not recognize pppoe dial-up interface and route out correctly. HOT 1
- Kernel version detection does not work with vDSO disabled HOT 6
- Allow changing line info data in btf.Line HOT 11
- load program: invalid argument: unknown func bpf_redirect_peer#155 (51 line(s) omitted)
- With the program type raw_tracepoint, no data is generated.error: loading objects: field TraceSchedWakeup: program trace_sched_wakeup: load program: permission denied: 5: (61) r1 = *(u32 *)(r7 +2784): R7 invalid mem access 'inv' (5 line(s) omitted HOT 1
- Test TestPerfReaderWakeupEvents gets stuck on some runs HOT 9
- With Linux 4.9, loadBpfObjects() failed, error=argument list too long HOT 1
- program: relocation of program targeting a module fails if CONFIG_DEBUG_INFO_BTF_MODULES is disabled HOT 3
- Unusual `go` directive in `go.mod`
- flake: TestMapIteratorAllocations HOT 1
- TestHaveProgramType/Extension fails on kernels >6.7 HOT 2
- ci: arm64 tests fail HOT 4
- deprecation of directive `//go:linkname` HOT 3
- AttachXDP failed on Ubuntu 20.04, kernel version is 5.4 HOT 3
- program: make it harder to attach Kretprobe via link.Kprobe and vice versa
- btf: CO-RE: types from (other) kmod BTF are not available HOT 3
- map Lookup allocates when key does not exist HOT 3
- DATA RACE: github.com/cilium/ebpf.(*MapSpec).createMap HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ebpf.