bpf2go: identifiers for UPPER_CASE symbols are not converted about ebpf

[ti-mo]

internal.Identifier() is used to generate internal/sys/types.go and is responsible for e.g.

type Cmd uint32

const (
	BPF_MAP_CREATE                  Cmd = 0
	BPF_MAP_LOOKUP_ELEM             Cmd = 1
	...
)

This might be stating the obvious, but all-uppercase enum keys like FOO_BAR are widely used in the kernel and C projects in general as globally-unique values that make grepping large codebases possible. Sharing these identifiers between Go and C is desirable, so we're not going to change this behaviour by default. The convention is to stick to CamelCase, but this is still just a convention, not a requirement by spec. We're better off breaking the convention to keep things recognizable here.

It's common to create Go-friendly aliases for frequently-used enums whose names are too long (const LookupAndDelete = BPF_MAP_LOOKUP_AND_DELETE_ELEM).

I get the tendency to want to change this, but I'm not convinced it's worth the additional complexity. As I've mentioned, these enums are uppercased for visibility/uniqueness, and it's often better to preserve them to keep things clear and consistent. If this is not required, why not modify the enum on the C side to be lowercased?

[MarcusWichelmann]

Ah, thank you for clarifying the reasons why it's currently done like that. Good point with the aliases. We'll probably go this route then.

[ti-mo]

Great, thanks for the reply! Closing this.