Comments (5)
Can you review this again? This is how it is implemented at the moment and is exactly as you mentioned. Have a look at the code please: https://github.com/CityZenApp/CityZen-Android/blob/master/CityZenApp/app/src/main/java/com/cityzen/cityzen/Utils/MapUtils/OpeningHours/OpeningHoursUtils.java
CityZen supports some of the date formats as documented at this link, but not all of them at the moment: http://wiki.openstreetmap.org/wiki/Key:opening_hours. Having said this, it shouldn't be an issue since we have based the hours system based on OSM. What do you think?
I'll have a look at the code ...
My comment was made following an edit I made using CityZen app (see http://www.openstreetmap.org/changeset/51206307) : opening_hours = Mo-Sa 18:30:22:30
from androidapp.
@jbelien thank you so much for taking the time to review the app even in the early alpha version of it. We will wait for some more days to get more feedback from you and other testers in order to review and implement the changes. Again thanks for getting involved, we really appreciate it.
If you have other comments and have found some more bugs please add them here @ Github.
from androidapp.
Here are some comments based on your feedback @jbelien:
impossible to enter/edit houser number (also impossible to view the house number);
Valid point. We were based on the needs of Tirana address system when we created this. This will be added on the v1.0 that will be released on F-droid.
Impossible to enter/edit postal code (also impossible to view the postal code)
Another valid point. Same answer with the previous issue.
It's only possible to enter the same opening hours for each day but there are a lot of shops/restaurant that have different opening hours if it's the week or the weekend.
Valid, but we were thinking of adding this at v2.0 release. If you or someone else can help us coding this would really help us (blame limited resources at the moment).
The format of opening hours is wrong ! Should be hh:mm-hh:mm (with a dash) instead of hh:mm:hh:mm !
Can you review this again? This is how it is implemented at the moment and is exactly as you mentioned. Have a look at the code please: https://github.com/CityZenApp/CityZen-Android/blob/master/CityZenApp/app/src/main/java/com/cityzen/cityzen/Utils/MapUtils/OpeningHours/OpeningHoursUtils.java
CityZen supports some of the date formats as documented at this link, but not all of them at the moment: http://wiki.openstreetmap.org/wiki/Key:opening_hours. Having said this, it shouldn't be an issue since we have based the hours system based on OSM. What do you think?
from androidapp.
@jbelien can you please test this again using the latest version that is launched on F-Droid? You can find it here: http://cityzenapp.co/.
from androidapp.
@jbelien some feedback regarding your comments below:
Impossible to enter/edit houser number (also impossible to view the house number)
This is implemented in version v 1.0
Impossible to enter/edit postal code (also impossible to view the postal code)
Also implemented in v 1.0
It's only possible to enter the same opening hours for each day but there are a lot of shops/restaurant that have different opening hours if it's the week or the weekend
@sidorelauku can you add a separate issue for this? Planned for ver 1.3. Once done let's close this issue please. Thanks
from androidapp.
Related Issues (20)
- Design: dark theme development HOT 1
- Offering Copywritting Contribution To Your Project HOT 17
- Add Toilets/Restrooms in the List of Categories HOT 1
- Spanish language is replaced by duplicate Basque language HOT 5
- Improvements on FDroid page HOT 2
- CityZen offline usage ? HOT 2
- A Display Bug
- Opening times malformed on upload
- Some POIs are not found
- Private parking is listed
- "No services found" is shown on error
- Refreshing the map
- Bad Request (400) - Bad OAuth request.
- Support App Specific Language
- Deprecation of HTTP Basic Auth and OAuth 1.0a
- Code contains README, NOTICE, and CONTRIBUTING files
- Licenses and copyright related questions
- Software releases related questions HOT 1
- Software quality of the project HOT 1
- Search functionality: showing the distance of POIs from user location
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from androidapp.