cityzenapp / androidapp

CityZen Android App, OpenStreetMap base-map

CityZen Android app

Openstreetmap contributor

Screenshots

How to contribute

If you want to contribute to CityZen, you are very welcome:

• on our Telegram group
• for translations of the app on Weblate
• opening issues and PRs

License

Software code is licensed under a Mozilla Public License 2.0

Covered Software is provided under this License on an "as is"
basis, without warranty of any kind, either expressed, implied, or
statutory, including, without limitation, warranties that the
Covered Software is free of defects, merchantable, fit for a
particular purpose or non-infringing. The entire risk as to the
quality and performance of the Covered Software is with You.
Should any Covered Software prove defective in any respect, You
(not any Contributor) assume the cost of any necessary servicing,
repair, or correction. This disclaimer of warranty constitutes an
essential part of this License. No use of any Covered Software is
authorized under this License except under this disclaimer.  

• Geoinformational data are based on OpenStreetMap platform which is published under a Open Data Commons Open Database License as documented here.
• Android icons under APL2

androidapp's Issues

Putting more screenshots on the internet

It would be nice to have a documentation of all the screenshots of the app with tagged pictures and examples for people who do not have mobile phones to see what the app looks like and be able to reference pages and features. So could you please create a users guide with all the screens in the app for review?

Search page needs new design

The search page needs e new design and UX design since now it is really confusing. The Nextcloud app is a good example as an approach. See #46 for better understanding. The 'nothing found' message should be fun and clear.

Ver. 0.6: location icon on the map

On the map page it is not easy to see where the actual location is with the actual color of the image. I propose to use a more distinguished icon-color and make it easier to understand where the actual location is.

Adding Bakery as a category

Following the proposal of adding a post office (#62) I'd like to propose to also add 'Bakery' as an additional category. Adding this on the list of features for ver 1.3.

Editing form

Hi,

I have some remarks about the form to edit an POI (I tried to edit informations about amenity=restaurant) :

• Impossible to enter/edit houser number (also impossible to view the house number)
• Impossible to enter/edit postal code (also impossible to view the postal code)
• It's only possible to enter the same opening hours for each day but there are a lot of shops/restaurant that have different opening hours if it's the week or the weekend, see #87

Warning :
The format of opening hours is wrong ! Should be hh:mm-hh:mm (with a dash) instead of hh:mm:hh:mm !

Also, it send a changeset request every time you tap on the mark to save your changes. I think it should only send a request if there is a change ! (see http://www.openstreetmap.org/node/866333004/history ; I accidentally double tapped on the mark and it sent 2 identical requests but with a "strange" message : Updatin for the 2nd changeset request)

Use opening_hour tags in display

When you list the POI's in the app, would be really useful to easily see if the POI is currently open or closed (comparison between current time and opening_hours tag)

Credits and license tracking

@valdio please add here the licenses of the different libraries (or other elements) used for the developed.

First test

First let me congratulate you for creating and working on such projects. Please read carefully everything. I am pointing out my experience.

Lenovo Vibe Z2
Android 4.4.4
Quad-core 1.2GHz
RAM/MEMORY: 2GB / 32GB

Installation: no issues

Running:
It is slow. Sometimes it crashes.

Functions:

SEARCH
Search is not functional or I cannot figure out what the result should be.
Say, I click on Restaurants, and I get Stela. If I search for Stela, results come empty. A message like "no data" or "search term not found" can help users understand if the search function is working or not.

DIRECTIONS
Direction not good. I click on Restaurants, and I get Stela. Then I click on Getting directions and it shows a straight line from point A to B. Not good.

Search functionality bug

The search functionality on the Alpha Version of the software doesn't work on many devices.
This is a comment from this bug - thanks. Creating a dedicated bug since it is an important feature. Search is not functional as reported by @kokushta and other users.

Display of the address

You display the name of the place in the address field in the information "popup".
I think it's a bit confusing !

Look at the screenshots here under,

• the first one is quite okay (even though the place name is repeated twice, which is not necessary) but
• the second one only display the name as the address, which does not make any sense.

Also in Belgium (and lots of other countries), we need the house number of the place ; the street is not enough to find (easily) the place.

No results in any category

Map is showing my position correctly however search returns no results in any category.

Bikes

Support different mode of transport like bikes for exemple. Will be great with the support of open bike sharing (http://openbikesharing.org) in the near future.

'Directions' bug

This is a bug reported from @kokushta in another bug.
Directions feature from point A to point B in many cases is not working. Scenario:
a user clicks on Restaurants, and gets POIs name X. If users clicks on 'Getting directions' it sometimes shows a straight line from point A to B.
We should avoid showing a straight line if the correct directions are not possible to be shown due to server taking ling to respond or any other issue. We might show an error message instead.
Of course the ideal scenario is that we limit the number of errors to be shown in general.

Post office indication

For the next version release I would like to propose to show on the home screen even the post offices near you.

Suggestions for Back button

Situation: I click on one of the categories and I get a list of places, then I click the selected place to get directions. It will be helpful to have a Back button to return to the list of places. This I guess will save additional requests to the app.

Add different type of directions

When users search for directions give them the possibility to request directions by foot, car, bike ,etc..

Have more categories

I would like to suggest other categories for the app:

Kindergarten
Schools
(these can be fit in one)

Universities

Markets

Playground
Parks
Amusements Parks
(these can be fit in one)

Shopping Malls

Parking places

Search functionality

In many cases search doesn't display any results. A 'no results found' message with ideally a related image needs to be displayed.

Regroup restaurants by cuisine

Could be nice to have the list of restaurants sorted/filtered/... by cuisine tag.
Usually people are looking for a specific kind of restaurant.

No GPS option

Hi! Please, add an ability to manual insert the position (for example, insert city name, etc.) for protect the privacy!

App usage metrics solution

We need to find a solution about the usage metrics of the app without compromising the privacy of our users. Let's work on finding a solution about this. The F-droid community forum might be a good start.

Ver. 0.6: adding the APK file to F-Droid repository

After the review of the feedback from users that are participating in the alpha version testing program, the APK that incorporates the changes and improvements needs to be added to F-Droid and www.fossdroid.com.
Fossdroid takes its data from F-Droid and organizes the apps in an attractive Google Play-like arrangement, with the ability to view apps by what’s new / trending / most popular.

Slow osm loading

Sometimes the osm base layer is slow on downloading. Tried it on 4g and wifi network. It does not happen all the time tho

Share Address With Other Apps

I think it could be useful to add a share option to send the selected poi to another app. For example, OsmAnd for navigation or a chat app to share your location with a friend.

Convenience store as part of supermarket category

Other categories and POIs can be added, while testing I am trying to figure out whats missing.
I find super market category resulting with a few POIs because it includes only features of tag shop:super market.
What about showing also mini-markets , POI type shop: convenience ?

Compass icon errors on screen density change

App version: 1.0
Xperia 6.0.1

How it looks at the default DPI (480): https://lut.im/ETfSjkgB9G/KtjlOkxpSCwcUVmj.jpg

How it looks (bigger icon) and behaves (arrows have different rotation centre) at a different DPI (424): https://i.imgur.com/Y5efVnQ.mp4

DPI can be changed via ADB with: adb shell wm density XXX

Only finding POIs mapped as nodes

When searching only results for POIs mapped as node are found. Those mapped as ways are ignored.

Category BikeRoad

Hello,
Could you add another category within my repository (https://github.com/shehuceljeta/Android-Development)?
The name of category:BikeRoad, icon: a bicycle. In this category will be display all the bicycle road in Albania(tag: highway=cycleway).(Like the logic of Transportation menu)
According to the location that user want to go, the app will display the road that must be followed in a map.
Thank you.

Bus stop showing bus routes

Transportation is always a subexplored area. Some ideas:

1. On selecting a bus stop, CityZen could show a list of bus routes that attend it.
2. Pay atention to the public_transport:version=2. Most of the existing based aplications don't support the new version. I mean, they don't recoginize route_master and stop_area. E.g., many times the name is on the stop_area only and not on platform/stop_position. Tags from/to are important too. Relation rules entry/exit(_only) the same way...

GPS get location fail

I opened the app and enabled the gps on my device. I went on the web map part of the application and it failed to show my current location. It still showed the last location known of mine, not my current.

When I search for a POI and tried to get the directions it updated my location.

Maybe when someone clicks on the map link the app should request the current location and update it accordingly. At the moment I think it shows the cashed coordinates.

This is the wrong location

Correct one

App creates OpenStreetMap tags with empty values

This app creates OpenStreetMap tags with empty values and other changes which look strange.

A tag key or tag value should be a non-empty string which neither begins with a space character (including tab, protected space etc.) or ends with a space character.

In addition, the user added an address (it was empty) to a so-called place node. This is wrong. Place usually do not get addr:*=* tags.

EDIT: add link to buggy changeset

Translation of URL's and email address

I started to translate CityZenApp in French (https://hosted.weblate.org/projects/cityzen/strings/fr/) and I noticed that URL's and email address are in the words to translate ... but that doesn't make any sense to translate those.

For instance (in strings.xml file) :

<string name="domain">www.cityzenapp.co</string>
<string name="license_link">www.cityzenapp.co/license</string>
<string name="privacy_policy_link">www.cityzenapp.co/app-privacy-policy</string>
<string name="email_contact">[email protected]</string>
...
<string name="get_involved_link">www.github.com/CityZenApp</string>
...
<string name="credits_link">www.cityzenapp.co/credits</string>

IMHO those strings have nothing to do in that file and could be "hardocded" in the code.

Results affected by the way of mapping

The way how a feature is mapped affects the result that we get from the app. There are features like cafes, hotels, clubs, restaurants, supermarkets etc which a mapper can add them on a map as a node or as an area, when the whole building is for this purpose.
The app only shows POIs which are a node in the map, a single point. I saw that when I new that a hotel was in the OSM data but wasn't shown on the app, verified this with all the other categories.
Getting less data then expected might also be from the ways how it's mapped, but I wanted to add this as a factor that influences search results.

Contrast of category background colors

The different category background colors are quite bright, so that the white icons and white text on it are sometimes very difficult to read. Either using darker colors, or black icons & text would improve that.

You can check it nicely at http://accessible-colors.com

Results' ranking by the closest location

Would be good to rank the results starting by the closest one to the current mobile location.
I think this will save lots of time for the user and is useful.

Add ability to define search radius

What is the current search radius ?

It would be really nice to be able to define the search radius in the settings page.

Results missing on categories even when they are on the map

Ass I mentioned on issue 24 when I search on an category it donesn't give me all the results. I saw from the code that the radius was 600m. From the screenshot I am showing where a hotel is( green color) and where I'm (red color) also because the routing is not functioning right now.
Category hotel/hostel only shows me one hotel which is twice as far as this one. I see the problem from filtering results, because on the code it only searches for a single point, while this hotel (and other properties also) is not mapped as a single point but as an area which means there is more than a pair of coordinates (longitude,latitude).

Hide feature

Please, consider adding a hide feature. Some locations have a lot to offer. A user might want to mark places not to be shown next time the app is used. This would be the opposite of the like function.

Because an entry is no longer visible, there should also be an extra overview to see what has been hidden by the user, with for each entry or all entries the function to unhide them again.

Implementing this function will allow users to do research a location form another approach than the like function; filtering out what is definitely not interested.

App logo needs to be changed

On the next release I propose to change the logo of the app, with the latest we are using on our communications channels.
@AnXh3L0 can you please help with this?

Launch of v1.1.0 on F-droid

Let's work on launching v1.1 on F-Droid. Goal: 15.03.2018. Tasks:

• remaining changes implementation https://github.com/CityZenApp/Android-Development/issues?q=is%3Aopen+is%3Aissue+label%3A%22ver+1.1%22
• documentation of improvements on OSM wiki page of CityZen;
• blog post for our website (press release);
• follow the F-droid procedure to update.

Offline use

Add an option to download a specific city/region/etc. for use the app completely offline

Use user language

If available display the name in user language.

For instance display tag name:fr for French speaking user if available and if not display default tag name.

Implementation of tablet friendly version

Right now CityZen app is not optimized for tablet devices and we need to start working on that. Although this is labeled as an issue for ver 2.0 it is quite a lot of work to be done. Any help on this is highly appreciated.

Emptycontent view for favorites

On initial start, or when you don’t have any favorites yet, the view is completely empty. It looks a bit like an error, or things didn’t load.

For proper feedback, an empty state is great. Also see http://emptystat.es/

This is for example how we do it in Nextcloud:

Favorites page needs new design

follow up issue to #52 for the favorites empty page design.

The search page needs e new design and UX design since now it is really confusing. The Nextcloud app is a good example as an approach. See #46 for better understanding. The 'nothing found' message should be fun and clear.

Change of name at OpenStreetMap editing name of the app

When editing with CityZen app at OpenStreetMap changeset it shows that the contribution has been made using 'CityZen'. I think would be more accurate if the name of the app would appear as 'CityZen Android app'.

Stores with no openning time shouldn't disapear when looking for opened store

When you check the option to show only open store, stores with no opening time disappear along with the closed one's. It's not because you don't have its time that it's closed.
Instead they should be showed but under the ones that we are sure are open.

Add ability to sign up on OSM using CityZen App

I was wondering if the ability to sign up for OSM using CityZen App is possible. This popup can be shown along with sign in

android.view.ViewRootImpl$CalledFromWrongThreadException: Only the original thread that created a view hierarchy can touch its views.

I found a crash during evaluating my automated testing tool.
It seems that the GUI cannot be updated asynchronously in another thread.
It might be a trivial bug. Stack trace is below.

// CRASH: com.cityzen.cityzen (pid 26902) (elapsed nanos: 12184728523014)
// Short Msg: android.view.ViewRootImpl$CalledFromWrongThreadException
// Long Msg: android.view.ViewRootImpl$CalledFromWrongThreadException: Only the original thread that created a view hierarchy can touch its views.
// Build Label: google/hammerhead/hammerhead:6.0.1/M4B30Z/3437181:user/release-keys
// Build Changelist: 3437181
// Build Time: 1478203422000
// android.view.ViewRootImpl$CalledFromWrongThreadException: Only the original thread that created a view hierarchy can touch its views.
// 	at android.view.ViewRootImpl.checkThread(ViewRootImpl.java:6556)
// 	at android.view.ViewRootImpl.requestLayout(ViewRootImpl.java:907)
// 	at android.view.View.requestLayout(View.java:18728)
// 	at android.view.View.requestLayout(View.java:18728)
// 	at android.view.View.requestLayout(View.java:18728)
// 	at android.view.View.requestLayout(View.java:18728)
// 	at android.view.View.requestLayout(View.java:18728)
// 	at android.view.View.requestLayout(View.java:18728)
// 	at android.widget.RelativeLayout.requestLayout(RelativeLayout.java:360)
// 	at android.view.View.requestLayout(View.java:18728)
// 	at android.widget.RelativeLayout.requestLayout(RelativeLayout.java:360)
// 	at android.view.View.requestLayout(View.java:18728)
// 	at android.widget.RelativeLayout.requestLayout(RelativeLayout.java:360)
// 	at android.view.View.requestLayout(View.java:18728)
// 	at android.support.v7.widget.RecyclerView.requestLayout(RecyclerView.java:3852)
// 	at android.support.v7.widget.RecyclerView$RecyclerViewDataObserver.onChanged(RecyclerView.java:4937)
// 	at android.support.v7.widget.RecyclerView$AdapterDataObservable.notifyChanged(RecyclerView.java:11359)
// 	at android.support.v7.widget.RecyclerView$Adapter.notifyDataSetChanged(RecyclerView.java:6636)
// 	at com.cityzen.cityzen.Adapters.PlaceListAdapter.resetAdapter(PlaceListAdapter.java:71)
// 	at com.cityzen.cityzen.Fragments.SearchFragment$1$1.run(SearchFragment.java:149)
// 	at java.util.Timer$TimerImpl.run(Timer.java:284)
// 

Add zoom buttons in the map

I usually use my phone with one hand ;
Would be really useful to have a zoom +/- button in the map.

I know to zoom I just have to double-tap the screen (and it works really well) but to unzoom a button would be convenient I think !