cjpetrus / url2img Goto Github PK

This module very often creates errors on some urls. My domain "http://stefanschwartze.com" I get almost never to work, maybe in 1 of 10 cases or less. This also occurs on other websites. I've also seen that sometimes it resolves the promise without saving the image.
I used the default settings from your Readme..

Hi,

Cool that you have improved my url-to-image module, looks awesome.

Anyways, I think we should join our efforts and maintain a one good tool instead of two separate ones. What do you think?

The README says that --crop-height takes a string argument, which is odd. I would expect it to take no argument (crop to viewport), or maybe a boolean or a number.

Anyway I have tried:

url2img --width 400 --height 200 --crop-height --kill-timeout 600000  http://google.com google.png

but the image isn't being cropped. In fact the output image size is 604x450. And the same if I use --crop-height true

If I use --crop-height 200 then no screenshot gets saved at all, but the process still takes time before it exits with return code 0 and no error message.

Am I doing something wrong? Cheers.

Details: npm v3.9.5 node v6.2.2 phantom 1.0.3 (I installed url-to-image before finding this fork)

The fileQuality parameter (used in oldOpts when calling page.render() in this line) is incorrectly named. I noticed that any value provided for the fileQuality parameter does not affect the quality or filesize of the output image. Renaming the parameter to quality instead of fileQuality (following the PhantomJS documentation) solves this issue.

I have tested it with phantomjs-prebuilt 2.1.4. Works fine. IMO it will be a good idea to bump the version. Unless there is something that I am missing.