GithubHelp home page GithubHelp logo

Comments (5)

Mte90 avatar Mte90 commented on May 5, 2024 1

I know that in GitHub is possible to reset the list of contributors from a specific date.
Contacting the support they can do that so we will have a reset point but for the future when we merge commits this will be a little problem.

from classicpress.

nylen avatar nylen commented on May 5, 2024

We'll need to build something to recognize "Props" lines in commit messages. For example, from 36152b6:

Props @Pross.

from classicpress.

pattonwebz avatar pattonwebz commented on May 5, 2024

History squashing to clear out props to past WP contributors may be possible on the repos history but I would encourage you NOT to do that.

While those people are not contributors to classicpress right now they still were in the past (albeit via CP forking their work) and as such they still deserve props and recognition. Also I believe morally it is much preferable to retain original credits (and indeed a requirement of the GPL freedoms that we both are granted and must offer).

from classicpress.

nylen avatar nylen commented on May 5, 2024

History squashing to clear out props to past WP contributors may be possible on the repos history but I would encourage you NOT to do that.

Agreed, we are definitely not going to rewrite the commit history.

I think the discussion above refers to asking GitHub to only count contributions in the graphs starting after our fork point, which they can do, but I'm not convinced this is necessary or valuable either.

Edit: Also, generally when we merge changes from WP, this is usually not at the direct request of the original author, even though their authorship information is still present in our merged change. I have been thinking that we would not count these contributions as intentional contributions to ClassicPress by default, but we do still preserve attribution so that we can recognize them as appropriate.

from classicpress.

nylen avatar nylen commented on May 5, 2024

As a specific example of something we need to be able to do here, ideally in a (semi-)automated fashion:

#419 was written by @bahiirwa , and he used code (patches) by https://profiles.wordpress.org/redsweater/ (Daniel Jalkut (Red Sweater)) in the PR. These patches are originally from https://core.trac.wordpress.org/ticket/45322.

We didn't think to record Daniel as the original author of the patch in the commit history, but we should definitely make note of this somehow.

I think a good solution would be a script that generates/updates a contributors list based on our commit history, and maybe we'd just manually edit the list for special situations like this.

cc @danielj

from classicpress.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.