Comments (5)
I know that in GitHub is possible to reset the list of contributors from a specific date.
Contacting the support they can do that so we will have a reset point but for the future when we merge commits this will be a little problem.
from classicpress.
We'll need to build something to recognize "Props" lines in commit messages. For example, from 36152b6:
Props @Pross.
from classicpress.
History squashing to clear out props to past WP contributors may be possible on the repos history but I would encourage you NOT to do that.
While those people are not contributors to classicpress right now they still were in the past (albeit via CP forking their work) and as such they still deserve props and recognition. Also I believe morally it is much preferable to retain original credits (and indeed a requirement of the GPL freedoms that we both are granted and must offer).
from classicpress.
History squashing to clear out props to past WP contributors may be possible on the repos history but I would encourage you NOT to do that.
Agreed, we are definitely not going to rewrite the commit history.
I think the discussion above refers to asking GitHub to only count contributions in the graphs starting after our fork point, which they can do, but I'm not convinced this is necessary or valuable either.
Edit: Also, generally when we merge changes from WP, this is usually not at the direct request of the original author, even though their authorship information is still present in our merged change. I have been thinking that we would not count these contributions as intentional contributions to ClassicPress by default, but we do still preserve attribution so that we can recognize them as appropriate.
from classicpress.
As a specific example of something we need to be able to do here, ideally in a (semi-)automated fashion:
#419 was written by @bahiirwa , and he used code (patches) by https://profiles.wordpress.org/redsweater/ (Daniel Jalkut (Red Sweater)) in the PR. These patches are originally from https://core.trac.wordpress.org/ticket/45322.
We didn't think to record Daniel as the original author of the patch in the commit history, but we should definitely make note of this somehow.
I think a good solution would be a script that generates/updates a contributors list based on our commit history, and maybe we'd just manually edit the list for special situations like this.
cc @danielj
from classicpress.
Related Issues (20)
- Paste image from clipboard to upload HOT 2
- Add editor shortcode-button hook HOT 14
- Modify the folder structure used to upload media files into years HOT 4
- Replace Petitions Dashboard widget API HOT 11
- Fix custom post status bug (#12706) HOT 3
- Missing Instructions:: Run PHPCS locally before commit
- Missing Information: Working with JS and CSS files. HOT 1
- π‘ ClassicPress version issues and conflict with plugins HOT 17
- π‘ Add an Object-Relationship Table HOT 1
- π‘ Automate changelog and release notes generation HOT 3
- π‘ new default for attachment order by date instead of ID HOT 2
- π Cookie βwp-settings-4β does not have a proper βSameSiteβ attribute value HOT 5
- Add Chinese support π‘ HOT 4
- πwp-json/wp/v2/my-custom-post-type?_fields=title,meta.somefld is not rendering meta array HOT 3
- Increment security by removing filters from escaping/sanitization functions? HOT 1
- π‘ Add Additional Hooks Into Comment Display Class HOT 4
- Deprecate Farbtastic
- π Twig not rendered after migrating WP 6.4 multisite to CP 1.7.1 HOT 7
- WordPress/ClassicPress (WXR) Import Tool HOT 4
- π Plugins: Modal window doesnt open (TypeError: f.showModal is not a function) HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from classicpress.