ClassicPress updates should not overwrite composer.json about classicpress

[nylen]

invisnet
with #477, i remember we looked into that when including composer.json - did we miss something or just get it wrong?
James Nylen 12:37 AM
no, we looked into something different (what happens when migrating if composer.json already exists)
I don't think we really got that case right either
invisnet 12:38 AM
ah, that'd be it....
really goes back to the fundamental problem that it's in the wrong place
James Nylen 12:39 AM
composer wants to install from the repo where composer.json lives though, right? if that's the only way then there isn't really a better place to put it
invisnet 12:43 AM
there was a convo about subdirs etc iirc to solve that - not something for 1.x obvs
is there any existing logic for not overwriting files?
James Nylen 12:50 AM
I don't remember seeing anything like that.. the simplest fix would just be putting if ( $filename === 'composer.json' ) { continue; } in the right place
yeah, "if it doesn't exist, write it, otherwise leave it alone"
this works because composer.json (normally) doesn't change across releases
invisnet 12:54 AM
it'll change between v1 and v2 won't it?
nevermind - it'll change when johnpbloch/wordpress-core-installer changes as we've got a specific version in there
i think we need to change that to "^1.0"
James Nylen 1:04 AM
wfm

[nylen]

See also: ClassicPress/ClassicPress-Migration-Plugin#61