Comments (3)
Have you tried removing the .npmignore
file? Now that I think of it that might be an issue
from react-infinite-calendar.
Removing the .npmignore does bring all of the necessary files in, but not the dist/ dir. postinstall
still will not be able to create the dist/ directory needed to utilize the fork. After removing .npmignore, npm install
-ing from a fork looks like this:
➜ ✗ ls node_modules/react-infinite-calendar
CHANGELOG.md bin karma.conf.js src webpack.config.umd.js
LICENSE codecov.yml node_modules styles.css
README.md index.html package.json test
babel.preprocess.sass.js index.js server.js webpack.config.dev.js
There is no dist/ dir, so a build must occur via postinstall
. However, the build will fail because of babel, crossenv, etc - I think this is because when npm installs a package, it doesn't install devDependencies:
➜ ✗ ls node_modules/react-infinite-calendar/node_modules
lodash
I thought I could solve this by installing crossenv in the root of my project or globally, but actually there are a ton of other devDependencies that will need to be installed, too.
I was thinking maybe a valid solution is to use a bin/ script instead of crossenv which checks to make sure crossenv command exists, and then if it does, uses it, otherwise, ignores it, but then you would need that script to be executable in a windows environment as well if you really wanted to be able to build crossplatform (which is the point of crossenv).
I try to avoid any of these sneaky "dependencies" that then get utilized in the package.json file itself (crossenv, betterscripts, etc). Having the package.json looking into ./node_modules/*/bin/ is one of the weird and confusing magics of npm that probably should be reconsidered.
I think a lot of other people have been solving this type of problem - since the prolification of babel and webpack - by committing the non-best-practice of commiting dist/ to their repository. Aka no dist/ in the gitignore.
I have a pretty solid solution to this that would fix it, but the relative paths in your .babelrc to stuff like preprocessCss makes it impossible. PR was made at #50
from react-infinite-calendar.
Hey guys,
This should no longer be an issue with version 2.0.0
, .npmignore
has been replaced in favor of the files
property in package.json
Check out #73 for more details
from react-infinite-calendar.
Related Issues (20)
- Selection don't work with 'onclick' events under iOS13 wkwebview
- Parent component update causes child calendar animation to break
- Broken theme while using range select and landscape
- Is it possible to add Month text support in locale? HOT 2
- onClickDay handler
- Selected date in input text not change follow the locale. HOT 1
- Getting warnings of componentWillReceiveProps HOT 3
- Calendar is jumping to the center of the screen on open HOT 1
- Adding events HOT 1
- Will this support React Hooks ?
- Disabling days does not work as expected when used with "weekStartsOn" option HOT 1
- Wrong value for year HOT 2
- Scroll resets to first selected element in a multipleDates calendar when state is updated HOT 3
- Changing locales does not change month names HOT 1
- Remove selection handler
- Cannot read property 'root' of undefined
- Blank calendar in init HOT 1
- Security audit fails due to a dependency in recompose HOT 1
- [enhancement] user can only select 'year' or 'year, month' or 'year, month, day'
- Warnings of componentWillReceiveProps and componentWillUpdate
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-infinite-calendar.