claudiohbsantos / github-material-icons-extension

Hey there, I'm Claudio Santos

A Software Engineer based in the US

Connect with me:

github-material-icons-extension's Issues

icon not showing in new project tree

When using the new project tree the icons won't be placed.
Actually, the new project tree where your project is expandable on the left doesn't have any icons.

Example for this project itself:

doesn't work as of 4/18/2023 Firefox Dev Edition

is it possible to copy the same configuration to vscode?

Extension crashes in Opera browser

Unfortunately, this extension failed in Opera browser and the icons did not load properly.

Improve build / bundling speed with ESBuild

I know the age old saying goes if it ain't broke... but could be good for reducing compute on GH actions, and developing locally.

I propose replacing custom build script and parcel with rollup & esbuild.

Feel free to close if this is not a priority / something you would be interested in.

Why is the 5 of the html icon not white?

I'd like to know, why isn't it white? in my dark theme it doesn't look good.

add icon to fql

hello icon material devs, I'm very satisfied with your icon theme, I love it I always use it, today I went to create a scraper with ferret, using fql a declarative scraper language for ferret, but the file didn't have an icon, add one icone for fql files, if you want an image here is one: image.

❤️ Thank you, until next time!

Per-repository language disambiguation

https://github.com/mathworks/MATLAB-Language-grammar/tree/master/test is matched wrong for example

By querying the API for the languages used in that repo, we can disambiguate between languages like MATLAB and Objective-C.

Extensions that need disambiguation are listed here, this issue applies to all mapped file extensions there

Symlink and submodule icons won't show when items match a known extension

Thanks for your efforts in resolving #3! Unfortunately when the items match a known extension:

(https://github.com/svartalf/rust-battery/tree/master/battery)

...the symlink and submodule icons won't show:

These lines should be hoisted (put in front of the languages matching code):

github-material-icons-extension/src/main.js

Lines 158 to 159 in f212d07

	if (isSubmodule) return 'folder-git';
	if (isSymlink) return 'folder-symlink';

Fix release process

It looks like the latest release didn't make it to the Chrome store due to the release action failing. Might be worth failing the pipeline if a task fails?

ESLint config is broken

While I was working on the PR I just submitted, I noticed that ESLint wasn't working. I looked into it and it seems that there are a lot of issues with the setup. First of all, eslint-config-airbnb is specifically for react projects, what you'd want to use is eslint-config-airbnb-base. Because of that, the config is failing due to a missing dependency of eslint-plugin-jsx-a11y which is only needed for React projects.

I tried updating the config with the proper configs and plugins, but there are a ton of cases where this project goes against the rules of airbnb's config. I'd be willing to give fixing this a shot because I enjoy fixing lint errors. However, it would involve a lot of reorganizing/tweaking of the code to make it valid, so I want to make sure this is something you'd actually want before I do anything. If not you might want to either choose a more lenient ruleset, or remove eslint from the project entirely.

If you do want this to be fixed, these are the initial changes I'd probably go off of to make it work (with some tweaks along the way most likely):

.eslintrc.json

{
  "env": {
    "browser": true,
    "es2021": true,
    "node": true
  },
  "globals": {
    "chrome": "readonly"
  },
  "extends": ["airbnb-base", "prettier"],
  "parserOptions": {
    "ecmaVersion": 12,
    "sourceType": "module"
  },
  "rules": {
    "no-use-before-define": ["error", { "functions": false }]
  },
  "overrides": [
    {
      "files": ["scripts/*.js"],
      "parserOptions": {
        "sourceType": "script"
      },
      "rules": {
        "import/no-extraneous-dependencies": "off",
        "no-console": "off"
      }
    }
  ]
}

.eslintignore

dist
node_modules

package.json

"devDependencies": {
  "eslint": "8.11.0",
  "eslint-config-airbnb-base": "15.0.0",
  "eslint-config-prettier": "8.5.0",
  "eslint-plugin-import": "2.25.4",
}

The extension might have been removed from the firefox addons page.

Following the link in the README gets me to a page which basically says the extension no longer exists and it is not included in the search results when searching for it, as far as I can tell it is still on the chrome webstore and the edge addons page.

Gitea & GitLab support

Hey

Thanks for your great extension.

Do you have any plans to support Gitea and GitLab?

Add support for VSCode Dev

Raising a feature req. to add support for VSCode Dev

Have started work on it, and will raise a PR in due course :)

Preserve symlink and submodule icons

Symlinked folders/files (including submodules) have a different icon to indicate their type, but this extension doesn't preserve it.

Without extension:

With extension:

Test repo: https://github.com/lxqt/lxqt

language error recognition results in icons error.

I use this extensions for verilog language(connect with vivado ,the file is .v). But it generate the wrong icon. Problem is that it make a mistake between verilog and vlang language(which is also .v). I tried some ways but still couldn't find the reason why it recognizes to vlang. So if there some methods to solove this problem?thank you.

New permissions

What for?

Icon size improvement

Hello,

This is a very nice extension!
I tried it and I immediately noticed an issue with the icons being too small compared to the original ones.

I added the following in main.js (after const newSVG = document.createElement("img");):

newSVG.style.width = "20px";
newSVG.style.height = "20px";
newSVG.style.marginTop = "1px";
newSVG.style.marginBottom = "-1px";

This makes it so much better IMO. Please try it out / consider this.

add support for Nestjs framework

Docker related icons issue

Docker icons are outdated maybe test the updates to icons will fix the issue.

Nightly build to the extension

Seems like many icons are missing in the browser but present in the VSCode with the respective material theme. Please do update the addon and if possible can the extension be auto-updated with some schedule using GitHub actions.

[icon request] html

Dear Juan, nice to say hello, I would like to request that the 5 of html be white. Since for clear topics this is not affected. However on dark backgrounds this one looks much better. Comparative image attached.
Hoping for a good reception, I say goodbye.

Duplicated Icons when changing icon Packs on 1.8.0

Just recording that I've noticed a small bug with the version that I just released where changing icon packs results in duplicated icons until refresh:

Pretty sure this is just a side effect of some of the changes to the icon replacement logic we introduced in #56 . Overall I'd rather live with this for a bit than revert since a lot of people seem to be using the new code view.

@csandman just tagging you for visibility, I'm happy to take a stab at it .

.webmanifest file extension recognized in vscode theme but not in github

In my repo AdamRaichu/adamraichu.github.io I have a file manifest.webmanifest that I was messing around with. In vscode, it has the JSON file icon, but on GitHub (using the extension) it has the generic file icon.

Doubled icons when used with Refined GitHub

found on this repository by clicking on code

When will the sidebar icon theme extension be supported

Add support to change the languages icons

Add support to configure languages and file associations just like we do in VSCode settings over here?

	"material-icon-theme.languages.associations": {
		"php": "php_elephant"
	},

Suggestion: Although Chrome extension can be run on Edge but also is there any plan to release it for the MS Edge store!!

JSON show node icon?

First off, excellent project, mad respect, etc.
Anyhow, why do JSON files show the Node.js logo?

Firefox: Unable to Install: Appears to be corrupt

Firefox version:
78.14.0esr

Addon version:
v1.4.2 (latest release as of now)

Steps to reproduce:
Follow the steps provided in the README:

• Download release for Firefox
• Install via about:addons -> "install from file"
• see error "appears to be corrupt" (screenshot attached)

Other Solutions I tried:

• Cloning the repository and zipping it myself

Add support for Submodule directory

Just like we do have custom icon support for Directory, there also exists a Submodule directory that should be looked after :)

Dark/Light theme detection

Moving discussion from PKief/vscode-material-icon-theme#1105 to here

Support `visualstudio.com` url for Azure Repos

I think this should be a fairly straightforward addition to the switch statement

Add option for file prefixes

To have all of our files sorted by type we name them type.*.ts. It would be great if we could specify this pattern in the settings of the extension.

Is there any plan for Safari?

I wish this repository can support Safari in the future as I love it too much. 😭

components icon missing when icon pack is angular

When icon pack is angular the components icon is crashing:

However, if we select React / Vue or nest components icon seems to work.

Doesn't work work on nested routes on Arc Browser

Hi, I noticed that this extension doesn't work on nested routes on Arc Browser (which is chromium based)

I tested it on Brave and everything was fine.

The repo from the screen is here

icon for *.nims file

*.nims is a nimscript file. It can use a same icon as *.nim file.

CSS logo should be consistent with the HTML logo

As you can see, the CSS logo isn't consistent with the HTML one. The CSS logo should look something like this just to keep consistency between icons:

Doesn't work on the new code view

The new code view with the tree sidebar is in beta right now (github docs), but the extension doesn't work with it :(

File chrome-extension://bggfcpfjbdkhfhfmkjpbhnkhnpjjeomc/file.svg is missing

When using v1.7.8, I opened the repo https://github.com/FabricMC/fabric/tree/1.19.4. The icon for the file called HEADER did not load. Apparently it was trying to reference the missing file file.svg.

Design flickers on hard reload on GitHub

If I tried to hard reload the repository page with cached cleared this kind of design flicker is happening and soon gets disappeared. @Claudiohbsantos can you investigate this I tried but couldn't figure out the culprit styling.

Extension not supported in new code view mode

The recently implemented new code view completely breaks the extension's functionality

Currently the mode is in feature-preview, so probably not a top-priority

How this repository currently appears with the feature enabled

Folder icon broken

The constructor folder icon is broken

Reference URL: https://github.com/inc2734/snow-monkey/tree/master/app

Matching multiple file extensions automatically

Quick sketch for this:

const fileName = 'phpcs.xml.dist.sample';
const fileExtensions = [];
for (let index = 0; index < fileName.length; index += 1) {
  if (fileName[index] === '.') fileExtensions.push(fileName.slice(index + 1));
}

Support for the Opera browser

Is there any possibility of adding support for the Opera browser?

Support Firefox

Do you have any intention to publish this extension to the Firefox addons marketplace?

GitHub enterprise support

Can we have GitHub enterprise support on this extension?
e.g. github.x.com

I think making and option to add site access would do the job.

Extension not found on Firefox Add-ons store

Oops! We can’t find that page

I installed the extension from source, and it works fine, but it would be cool if you guys solve this issue with Mozilla.

Sometimes icons will be missing

I found if we have a large number of files present then sometimes icons get missing for files.

Github action is broken for update upstream

@Claudiohbsantos VSCode extension had been released but over this repo action, it is being broken. Can you please look into it?