clembou / github-requests Goto Github PK

this would ensure other apps can programmatically create issues without having to worry about formatting, labels, etc.

We need to find a way for users to upload screenshots that will be uploaded somewhere and accessible from github.

We could either add them as images in markdown in the body of requests once the screenshots have been uploaded, or just add a formatted link at the bottom of user requests pointing to the uploaded images.

Azure storage seems like the obvious option but there may be alternatives. The content of the screenshot is sensitive so the chosen solution will need to be secure and files should have restricted access.

for the list of projects configured in the app, it should be possible to see associated github releases.

To support the use case when more than one application are released from the same repo, a project specific tag name prefix may be needed.

Admin consent link should not be as visible as it is now, and feedback should be given based if consent was granted successfully.

The "toggle admin" link in the profile drop down should only be shown in dev mode.

The current authentication flow is complicated because the app is using both Azure AD authentication an Github Authentication. Splitting it in two separate apps targeted at two different groups or users ( github users on one side, company employee on the other) would make things a lot easier.

it currently says "React App"

The current format of the project config file is not very practical in some cases. It would be easier to work with if the data was flattened:

{
    "groups": [
        {
            "name": "group 1",
            "key": "group1",
            "description": "These projects are related to each other."
        },
        {
            "name": "group 2",
            "key": "group2",
            "description": "These projects are related to each other."
        }
    ],
    "projects": [
        {
            "name": "Test 1",
            "tagName": "test1",
            "organisation": "clembou",
            "groups": [
                "group1"
            ],
            "repository": "test"
        },
        {
            "name": "Test 2",
            "tagName": "test_2",
            "organisation": "clembou",
            "groups": [
                "group2"
            ],
            "repository": "test"
        }
    ]
}

azure tokens are valid for one hour only. Currently we do not check if a token is still valid before attempting to use it, nor do we try to renew it.

Deploying the react app to azure takes about 100 minutes. Most of this time is taken up with huge amounts of logging information from Babel of the form:

2017-03-28T15:44:50    Tue, 28 Mar 2017 15:44:50 GMT babel program.body[10].body.body[6].body.body[2].declarations[0].init.right.openingElement.attributes[0].value.expression.body CallExpression: exit
2017-03-28T15:44:50    Tue, 28 Mar 2017 15:44:50 GMT babel program.body[10].body.body[6].body.body[2].declarations[0].init.right.openingElement.attributes[0].value.expression ArrowFunctionExpression: exit
2017-03-28T15:44:50    Tue, 28 Mar 2017 15:44:50 GMT babel program.body[10].body.body[6].body.body[2].declarations[0].init.right.openingElement.attributes[0].value JSXExpressionContainer: exit

We need to stop this happening so that the deployment can happen more quickly.

Issue comments should be displayed in the app, and users should be able to comment on requests.

@ceddlyburge I never saw this before but it looks like Github is flagging security vulnerabilities in some packages... https://github.com/clembou/github-requests/network/dependencies

It is probably worth fixing and easy to do - I won't do it since I am unable to check that the app still works though.

remove placeholder text like "project name here etc"

Basic functionality is implemented in the app but it currently looks pretty bad. Once all the basic features are in we should improve the UX and design.

there is a placeholder page but it does not do anything.

This used to work fine, I may have broken it when extracting the navbar into a separate component.

This used to work.

So far I have not really done anything to support mobile devices, it would be nice if the app could look decent on small screens.

Users will soon receive notifications once #22 gets merged, and may want to click on the link in the "request closed" notification for example.

We should :

• load closed issues
• add a toggle to show open or closed requests in the request list ui
• make direct links to closed issues work.

the bot name is shown instead of the original requester