Segfaults when outside, may be solar panel related? Sky island related? about cataclysm-dda

[RenechCDDA]

I got it to reproduce when loading the save the second time, it happened during loading. Interestingly, it's trying to draw... z+14?

That's way out of bounds.

Looks like it continues the while-loop even after reaching Z+10. I'm guessing it doesn't crash all the time because of how the memory is aligned - it only sometimes manages to escape valid memory and trigger the segfault. Still it shouldn't try to read anything past max height, there's definitely nothing there and it could end up reading bad data.

[RenechCDDA]

This should probably prevent the crash in the future, but the circumstances to trigger it aren't clear to me. I wasn't able to get it to crash more than the one time (with or without this patch).

index 0eaa347af9..c640f23c79 100644
--- a/src/cata_tiles.cpp
+++ b/src/cata_tiles.cpp
@@ -4049,6 +4049,9 @@ bool cata_tiles::draw_critter_above( const tripoint &p, lit_level ll, int &heigh
     // Search for a creature above
     while( pcritter == nullptr && !here.dont_draw_lower_floor( scan_p ) &&
            scan_p.z - you.pos().z <= fov_3d_z_range ) {
+        if( scan_p.z >= OVERMAP_HEIGHT ) {
+            break;
+        }
         pcritter = get_creature_tracker().creature_at( scan_p, true );
         scan_p.z++;
     }

[GuardianDll]

I've had this error a lot, i could not reproduce it properly, and it was almost completely gone when i changed my build from MSVC to other