clibs / http-get.c Goto Github PK

See https://curl.se/libcurl/c/CURLOPT_NETRC.html

It's the only thing keeping clib(1) from being self contained.

thoughts @jwerle @visionmedia?

👋 !

I am attempting a patch for clib that enables multi threaded downloads! I noticed the usage of a static http_get_request_t used here for the http_get() function. This can be unsafe as we return a pointer to the stack allocated variable. Threads running at the same time can both modify the variable the pointer points to, such as allocating new res->data pointer before the previous is free'd and leaking memory, not to mention multiple threads writing at the same time to the same res->data pointer in the http_get_cb.

This is a show stopper for now until this is addressed. I'l issue a PR soon!