clkao / ep_author_neat

Use colored underline for authorship instead of background color

ep_author_neat

Use colored underline for authorship instead of background color.

This requires etherpad-lite 1.3.0 or later.

Left: original etherpad-lite; Right: ep_author_neat enabled

License: MIT

ep_author_neat's Issues

Unsettled function bug in hook function

Hi,

cool addon! Looks really neat and works almost flawlessly. :)
When starting a pad I get the following warning in the browser console:

UNSETTLED FUNCTION BUG IN HOOK FUNCTION (plugin: ep_author_neat, function name: ep_author_neat/static/js/index:aceEditEvent, hook: aceEditEvent): The hook function neither called the callback nor returned a non-undefined value. This is prohibited because it will result in freezes when a future version of Etherpad updates the hook to support asynchronous behavior. PadName line 24 > injectedScript line 24 > Function:67:1793
    callHookFnSync https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:67
    callAll https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:67
    callAll https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:67
    ee https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    te https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    ue https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    i https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    (Async: setTimeout handler)
    r https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    atMost https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    ue https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    ee https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    te https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    ue https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    i https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    (Async: setTimeout handler)
    r https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    atMost https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    ue https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    ee https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    te https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    ue https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    i https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    (Async: setTimeout handler)
    r https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    atMost https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    ue https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    ee https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    te https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    ue https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    i https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    (Async: setTimeout handler)
    r https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    atMost https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    ue https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    ee https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    te https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    ue https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    i https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    (Async: setTimeout handler)
    r https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    atMost https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    ue https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    ee https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    te https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    ue https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5
    i https://my.ether.pad/p/PadName line 24 > injectedScript line 24 > Function:5

If I can help with fixing this I'd be happy to. Thanks again!

plugin is disabling line numbering

Hi Chia-liang,

this is the issue regarding the not shown line numbers when your great plugin is acitvated.

Thanks

optionally show aggregated author name as line prefix

see #1

it seems updateLineNumbers is the right place to add hook.

Can we get rid of CSSStyleDeclaration?

I assume this is for css manager to work? should this be supplied by core?

use acePostWriteDomLineHTML to calculate primary author of a given line

use the primary color for line prefix, and only shows colored underline for different authors.

aka hackpad style

Improve primary author detection

currently it is line based. If an author is primary for a very short line within a large paragraph mainly by another author, we should be able to detect that and make the primary author of the whole paragraph primary as well for that line.

very long initial load time on big Pads

I have a big pad with ~3500 lines and ~170k revisions. If i install this plugin i have to click "continue execute this script" 5 times in Firefox before i can do anything in the Pad. On a small Pad it is doing really nice.

I am a newbie.. but i love your idea of ep_author_neat.

I forked a copy of the development tree, and cloned it for myself, since its my ambition to use your ep_author_neat. However, i cant get it to start... And everything else seems to be working fine. I am just trying and failing. could i email you about it?

flashing underline as I type

In chromium (ubuntu saucy), the color underline is redrawn after every key stroke, creating a mind numbing experience of flashing confusion.

Underlines flicker while typing

While typing, the authorship underline flickers below the current line, even if the line has only one author and therefore shouldn't show an underline. When I stop typing, the underline goes away as expected.

I plan to write a patch to fix this, but I have no familiarity with the code currently. Could you give me any guidance on where to look?

adding a break between 1 and 3 doesnt draw author

create 3 lines
write in them
1
2
3

then delete 2, you wont get an authorname on 3 unless you edit 3

removing chunks of content doesn't fire redraw

create lines 1 2 3 4 5 with content 1 2 3 4 5

delete lines 2 to 4, note that the blue author bar extends past viewable content. This is related to #5 and is a limitation introduced by the plugin hook that only returns the first line edited.

To fix this we need a way to iterate over the dom to find any future/previous lines that contain either:
a different author
OR
nothing

aggregate some author across empty lines

If there are empty lines between two chunks of primary author, both chunks show the name. the second one can be omitted.

deleting empty line not triggering enough authorview update

hiding author color when not focused in editing area

Publish latest version?

master is at v0.0.33 is committed, but the published version is v0.0.31. Would it be possible to publish the latest version?

Unknown author displayed as "null"

When refreshing a pad that has unnamed authors it shows up as "null" rather than Unknown author.

A line flashes under each edit

acePostWriteDomLineHTML fires after the css is applied

nice idea!

I really wish I could turn off the underlining though, because it is super distracting as it flashes every character

Removes line numbers

This plugin removes the file numbers. Can we get them back?

Typing really fast onto new lines doesn't draw authorname due to race conditions

Not really sure how to resolve this one..