GithubHelp home page GithubHelp logo

Comments (5)

megnotarte avatar megnotarte commented on June 12, 2024 2

I wonder if @Paul-Hebert or @aileenjeffries or @gerardo-rodriguez could review. I don't want to wait if we don't have to.

from cloudfour.com-patterns.

spaceninja avatar spaceninja commented on June 12, 2024

After testing the Gutenberg separator block, I think it serves the purpose:

Image

I'm going to move this to "in review" and assign it to Tyler so he can confirm when he comes back.

from cloudfour.com-patterns.

Paul-Hebert avatar Paul-Hebert commented on June 12, 2024

I think the separator block is sufficient. AFAICT there are two differences:

  • Slightly different color/thickness but they both look fine.
  • Different semantic meaning. The separator block adds a horizontal rule. But, I think a horizontal rule is fine here? It may not be necessary if it's followed by a heading but I don't think it's wrong.

This seems fine to me, especially if we have other tasks in the backlog to further optimize the article series experience

from cloudfour.com-patterns.

gerardo-rodriguez avatar gerardo-rodriguez commented on June 12, 2024

I agree with @Paul-Hebert!

from cloudfour.com-patterns.

spaceninja avatar spaceninja commented on June 12, 2024

👍 Sounds good! I'm marking this as "done."

from cloudfour.com-patterns.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.