Comments (2)
Going to take note of what I've found so far...
Our work
This seems fine as-is. It's a unique case where we want all of the items to feel a little more emphasized, and it takes one modifier to pull that off. Makes sense.
Article listings
I'm a little confused, because if I remove the 3-column modifier, it just seems better? It still caps at three columns, but the column count switches a little later, which feels more readable to me. I wonder why we set this. Maybe it was different before we adjusted container sizes? It seems like we could just remove the modifier in this case.
Speaking
This page doesn't use modifiers already, and it looks fine.
Team
This page was the initial source of criticism, and there are some awkward breaks here and there.
Most of these seem to be caused by switching to column modifiers too early and too infrequently. If we switch from 4-column@l
to o-deck--3-column@l o-deck--4-column@xl
, most of the awkward line breaks go away.
Single team member
As with the article listings, these don't appear any different if I remove the modifiers from them.
Takeaways
I went into this expecting to adjust the column widths, but when I tried doing that, it didn't really feel any better. I think maybe that value used to be out of step with our container width, but somewhere along the way we must have found harmony.
I think the action in this case isn't to make pattern changes, but to adjust some of the classes within our WordPress theme.
from cloudfour.com-patterns.
Okay, one wrinkle: I think we actually want auto-fill
instead of auto-fit
, because otherwise if there's only one or two items, they will take up ridiculous amounts of space.
Or maybe this should be an option... hmm...
from cloudfour.com-patterns.
Related Issues (20)
- Directional border utilities HOT 5
- Comment component docs in Storybook cause the browser to hang HOT 8
- Image block captions should be able to extend past the width of the image HOT 3
- Add ability to limit video width HOT 3
- Tables in comments are unstyled
- Allow Group block to use o-rhythm class
- Unable to require/import files other than main export in Node HOT 2
- [Contact Page] Make WordPress font size `big` utility responsive
- [Contact Page] Download icon
- [Contact Page] Add `c-input` modifier for more padding HOT 1
- Create Highlight theme in preparation for server-side rendering HOT 4
- Explore updates to our fluid type calculations for simplicity and accessibility
- Explore alternate button pointer effects
- Media-text block not handling most common use case very well HOT 1
- Embed block contents do not fill their container
- I would love a "Side Note" block
- Radio component
- Quote citation styles intended for WordPress blocks are leaking out to all blockquotes
- Inline code color has too little contrast against lightest gray
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cloudfour.com-patterns.