GithubHelp home page GithubHelp logo

Comments (2)

tylersticka avatar tylersticka commented on June 12, 2024

Going to take note of what I've found so far...

Our work

This seems fine as-is. It's a unique case where we want all of the items to feel a little more emphasized, and it takes one modifier to pull that off. Makes sense.

Article listings

I'm a little confused, because if I remove the 3-column modifier, it just seems better? It still caps at three columns, but the column count switches a little later, which feels more readable to me. I wonder why we set this. Maybe it was different before we adjusted container sizes? It seems like we could just remove the modifier in this case.

Speaking

This page doesn't use modifiers already, and it looks fine.

Team

This page was the initial source of criticism, and there are some awkward breaks here and there.

Most of these seem to be caused by switching to column modifiers too early and too infrequently. If we switch from 4-column@l to o-deck--3-column@l o-deck--4-column@xl, most of the awkward line breaks go away.

Single team member

As with the article listings, these don't appear any different if I remove the modifiers from them.

Takeaways

I went into this expecting to adjust the column widths, but when I tried doing that, it didn't really feel any better. I think maybe that value used to be out of step with our container width, but somewhere along the way we must have found harmony.

I think the action in this case isn't to make pattern changes, but to adjust some of the classes within our WordPress theme.

from cloudfour.com-patterns.

tylersticka avatar tylersticka commented on June 12, 2024

Okay, one wrinkle: I think we actually want auto-fill instead of auto-fit, because otherwise if there's only one or two items, they will take up ridiculous amounts of space.

Or maybe this should be an option... hmm... 🤔

from cloudfour.com-patterns.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.