cloudhx / github-issue-manager Goto Github PK

🐛 Bug Report

Sometimes closing one specific issue will also remove other issue(s) from the issue list.

🐛 Bug Report

When an authorized user re-authorizes with an invalid token, the issue list is still shown and user is able to refresh the issue list with the invalid token.

To Reproduce

Steps to reproduce the behavior:

1. Open the app
2. Navigate to Token page
3. Provide a valid personal access token and click Authorize button
4. Go to Issues page and inspect the issue list
5. Go to Token page, provide an invalid personal access token and click Authorize button
6. Go back to Issues page, the issue list is showing the same items as before
7. If clicking Refresh button, error message invalid personal access token is popped up

Expected behavior

The Sign-In component should be shown instead of Issue list.

According to GitHub API documentation:

GitHub's REST API v3 considers every pull request an issue, but not every issue is a pull request. For this reason, "Issues" endpoints may return both issues and pull requests in the response. You can identify pull requests by the pull_request key.
Be aware that the id of a pull request returned from "Issues" endpoints will be an issue id. To find out the pull request id, use the "List pull requests" endpoint.

Considering the below requirements refer in particular to the GitHub Issues feature, the pull requests should be filtered out from the issues returned from API.

As a bare minimum, the application should support:

• Signing into GitHub (e.g. using your Personal Access Token).
• Listing issues assigned to you.
• Closing issues one at a time.

🐛 Bug Report

When there are issues updated in GitHub, trying to navigate to another page and navigate back to the issues page doesn't update the issue list. Users have to refresh the page and log in again to get the latest issues.

To Reproduce

Steps to reproduce the behavior:

1. Open the app
2. Navigate to Token page
3. Provide a valid personal access token and click Save button
4. Go to Issues page and inspect the issue list
5. Go to GitHub, update some issues
6. Go back to the app and navigate from Issues page to another page, e.g. Home
7. Navigate back to Issues page, the issue list doesn't reflect the updates in GitHub

Expected behavior

The issue list should be updated when revisiting the Issues page without the need of refresh.

💡 New Feature

Add a refresh button to the issue list to retrieve updated issues from GitHub.

The following minor changes need to be implemented:

• Change nav text of issues page from Issues to Open Issues since current implementation only retrieve open issues from GitHub
• Change issue title in issue list from a <Link> to an HTML <a> tag. In the beginning, the app was supposed to have an issue details page, so a <Link> was used to route to the details page. However this task was dropped later and the issue title should be changed to an HTML <a> tag linking to GitHub issue details page in a new page.
• Show issue labels as bootstrap badges.

💡 New Feature

Users should be informed to authorize the app to GitHub when accessing the issues page without a valid personal access token provided.

The following warning found when running all tests after merging local master.

• Warning: Each child in a list should have a unique "key" prop.
• Warning: Invalid DOM property class. Did you mean className?

• Change token field label
• Other minor adjustments

Add repository full name to the issue list to show issues across different repos.

As a requirement, the project should include some basic testing.

The test approach is:

• Using Jest as the test framework
• Using React Testing Library as the helper library to test React components

Consider the following test plan which will test React presentation components:

• Test the token form used to submit personal access token to the system
• Test the issue list where all received issues should be listed
• Other basic tests

If time permits, consider adding tests for Redux.