Missing "root" alias aws provider definition in aws-sso component about terraform-aws-components

[MReggler]

It looks like this happened due to the sweeping changes to providers.tf that occurred as part of #715

Of note in this PR is that providers.tf that previously used module.iam_roles.org_role_arn and therefore required SuperAdmin deployment (such as aws-sso and account-settings), subsequently use terraform_role_arn which is not guaranteed to be the same for customers where terraform_dynamic_role_enabled is false in account-map.

I am unclear whether this is a separate bug or a intentional breaking change impacting legacy users, but I wonder if this, and the bug raised above, are a side-effect of components with bespoke aws provider configurations being updated to a standardised approach.

[milldr]

We encountered this mistake internally as well, and we have this open PR to resolve the issue:
#740

We also are creating an upgrade guide to explain the why and how of that sweeping account-map and providers.tf change. WIll link that once available

[Nuru]

@MReggler Thank you for opening this issue. Please feel free to try our proposed fix in PR #740 and comment on it there. In particular, if you are so inclined, I would value your feedback on the Change log regarding how well it answers your questions regarding SuperAdmin vs terraform_dynamic_role_enabled deployment.