cloudposse / terraform-aws-security-hub Goto Github PK

Describe the Feature

It woud be nice to pass down to eventbridge more configuration e.g. filtering by Severity Level to avoid sending Informational or Low findings to SNS. It can be additional input or maybe add possibility to input the whole JSON object.

Expected Behavior

I would like to send specific severity Findings to SNS.

Use Case

I want to reduce noise on the slack channel. See only Critical & High findings. Add later low level.

Describe Ideal Solution

Pass down as input entire JSON object to eventbridge
cloudwatch_event_rule_pattern_detail_type

Alternatives Considered

No response

Additional Context

No response

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Repository problems

These problems occurred while renovating this repository. View logs.

• WARN: Base branch does not exist - skipping

Edited/Blocked

These updates have been manually edited so Renovate will no longer make changes. To discard all commits and start over, click on a checkbox.

• Update Terraform cloudposse/kms-key/aws to v0.12.2 (main)

Detected dependencies

terraform

eventbridge.tf

• cloudposse/label/null 0.25.0
• cloudposse/kms-key/aws 0.12.1
• cloudposse/label/null 0.25.0
• cloudposse/sns-topic/aws 0.21.0

modules/control-disablements/versions.tf

• aws >= 2
• hashicorp/terraform >= 1.0

versions.tf

• aws >= 2
• hashicorp/terraform >= 1.0

---

• Check this box to trigger a request for Renovate to run again on this repository

Have a question? Please checkout our Slack Community or visit our Slack Archive.

Describe the Feature

When deploying in to China region the 'partition' in the ARN is aws-cn, where are the standard partition in only aws.
This module contains a hard-coded partition of aws for the root IAM ARN in the KMS Key Policy.
This causes the deployment to fail with the error that the Principle does not exist.

Expected Behavior

The KME key policy should deploy without issue and reference an ARN that is in the same aws partition.

Use Case

Such a change is required in order to be able to deploy into China

Describe Ideal Solution

The data source 'aws_partition' should be used to dynamically generate the partition portion of the ARN for seamless use.

Alternatives Considered

A parameter could be added that is either directly fed into the ARN or used in a lookup table first.

Additional Context

I'm creating a pull request with this feature soon

Have a question? Please checkout our Slack Community or visit our Slack Archive.

Describe the Feature

A toggle should be provided that is used on the delegated administrator account that activates AWS Organization Auto-enable feature for Security Hub. Thus all new accounts have Security Hub automatically enabled and send data to the delegated admin account.

Expected Behavior

A single deployment of this module in the security account during the early stages of the landing zone creation should be sufficient to manage all accounts in the org via that security account.

Use Case

The Security Hub delegated admin account is able to see and control the Security Hub deployment of other accounts in the AWS Organization.

Describe Ideal Solution

A single toggle should be set to true on the delegated admin account and then there is no need for this module to be deployed in any other account.

Alternatives Considered

Users can manually enable this feature via the console.

Additional Context

I'm creating a pull request with the implementation soon.