cmb-s4 / s4sim Goto Github PK

The NET calculation is site-specific and LAT bands in the Pole now have "P" included in the name to make them distinct from Chile.

The Chilean bands should similarly have "C" in their name and the SAT bands should follow the same naming convention. This would make it more intuitive and easier to use in scripting.

This issue also addresses the absence of Chile-specific SAT bands.

In https://github.com/CMB-S4/s4sim/blob/master/s4sim/hardware/config_3shooter.py

I think the LAT NET figures are by mistake the same as the SAT ones.

For example at

the LFL1 NET is 177, but that is the SAT value, from the DSR:

It looks like this issue mentioned in #30 didn't get fully resolved. All wafers in the CHLAT and SPLAT should have the same clocking, but HF is still different. Prior to the fix in the pull request, MF/LF are in the correct orientation, but HF is not. It looks like the rotation to fix HF was applied to all wafers such that HF is in the right orientation now, but MF/LF are not.

This is from prior to the correction showing MF/LF in the correct orientation, and HF not:

This is fro Reijo now showing that HF is in the correct orientation, but MF/LF are no longer correct:

When reading in the hardware map, define the per detector NET for a band as as the "NET" multiplied by "NET_corr" to account for the pixel to pixel correlations. Should add to the DC1 branch.

I am looking through https://github.com/CMB-S4/s4sim/blob/master/s4sim/hardware/config.py but I cannot find the sampling frequency of the channels.
I need that to crosscheck that my scaling of the hitmaps makes sense.
Can you please help me out?

Sorry, I can't find the number of detectors per tube either, can you please point me to those?

@keskitalo @smsimon

I think we need some documentation

even just adding something to https://github.com/CMB-S4/s4sim/blob/master/README.md

In particular about the hardware model:

• what is the difference between config config_1shooter and 3 shooter
• how do I get the baseline design
• should we rename get_example to get_baseline_design?

s4sim/s4sim/scripts/hardware_trim.py doesn't trim right for SAT5, LAT1, and LAT2. Includes other tubes.

s4sim/s4sim/pipeline_tools/pysm.py needs to be updated for S4

@keskitalo @smsimon

my first assumption was that MFH meant middle-frequency-high, instead looking at s4sim
it looks like the 1 channels are low and the 2 channels are high:

import s4sim.hardware.config
c=s4sim.hardware.config.get_example()
for ch in ["MFHS1", "MFHS2", "MFLS1", "MFLS2"]:
    print(ch, c.data["bands"][ch]["center"])
MFHS1 95.0
MFHS2 155.1
MFLS1 85.0
MFLS2 145.1

can you please confirm s4sim is correct as it is now?

It looks like the SAT beams are different between s4sim and the table in the DSR.

Do you know what is going on?