cmb69 / feedview_xh Goto Github PK

See http://cmsimpleforum.com/viewtopic.php?t=7958&p=44621#p44615.

In hindsight, it was a bad idea to pass a SimplePie instance to the template. While this offers a great amount of flexibility, it is hard to understand (users need to read the SimplePie API documentation), and error prone, since a rather large amount of methods is not supposed to be called from the template.

Furthermore, it does not shield Webmaster from possible API changes after SimplePie updates, and does not allow to swap SimplePie for another feed reader/parser (after all, SimplePie should be regarded as implementation details).

Therefore, it seems to be a good idea to only pass variables of built-in types to the view template.

http://cmsimpleforum.com/viewtopic.php?f=16&t=7958&p=44340#p44338

(also need to check for SimplePie requirements; and document them)

See http://cmsimpleforum.com/viewtopic.php?f=16&t=7958&start=20#p46266.

http://cmsimpleforum.com/viewtopic.php?f=16&t=7958&start=20#p44608

Bei mir tritt ein unerklärlicher Fehler auf beim Entpacken der Datei „Feedview_XH-1.1.zip“.

Im Ordner \feedview\views\ sehen die jeweils ersten Zeilen der beiden Dateien „feedview.php“ und „info.php“ so aus:

<?php php

use Feedview\Infra\View;
…

Mir ist nicht klar, woher das zweite „php“ in der ersten Zeile kommt.
Alle anderen PHP-Dateien sind nach dem Entpacken in Ordnung, nur die beiden oben genannten nicht.

http://cmsimpleforum.com/viewtopic.php?f=16&t=7958&start=10#p44338

While that is okay during development, we better avoid it for production builds, since that setting is often disabled.

https://github.com/simplepie/simplepie/releases/tag/1.8.0

See http://cmsimpleforum.com/viewtopic.php?t=7958&p=44583#p44338.

Well, let's go with PHP ≥ 7.2.0 so we can ship with the latest SimplePie (1.8.0).