cmb69 / twocents_xh Goto Github PK

... and move possible spam into the moderation queue. See http://cmsimpleforum.com/viewtopic.php?f=16&t=8863&start=20#p48977.

To avoid issues where MTAs may block unknown From addresses, the notification mail sets From to the configured address. That's reasonable, but reply-to won't work as expected. Therefore it would be nice if the Reply-To header would be set to the commenter's address.

Thinking that a step further, it also would be nice if the email's body would be more like normal email, i.e. the actual comment should be quoted.

Problem due to insufficient support.

The insert link dialog offers ok and cancel buttons, but pressing cancel still creates the link. Even worse, in case of cancelling, the resulting href is null (at least in Chrome).

The message does not mention which files had been imported. This is misleading if there are no files, for instance, because the user has put them in the wrong place.

See http://cmsimpleforum.com/viewtopic.php?f=16&t=7933&start=30#p43479.

This is rather mandatory to mitigate spam. See also https://support.google.com/webmasters/answer/96569?hl=en.

If a page name contains certain special characters and the page is not a toplevel page, wrong URLs are generated, which do not map to the page. See https://cmsimpleforum.com/viewtopic.php?f=10&t=13059 for detailed examples.

That's a problem of the current Url class, which does not especially cater to the "page URL" (i.e. $su), and so double percent encoding can occur. Since the Url class is also part of Pfw_XH, Pagemanager_XH, Foldergallery_XH, Uploader_XH and Cryptographp_XH these plugins may also be affected by this bug.

commit 6b44704 suggests that new comments are added via Ajax, but this is not the case for a markup-less configuration (comments_markup="").

While a scrolling textarea is fine (at least on contemporary browsers which allow to manually resize it), a scrolling div is not. Offering a resize handle would be best, but at the very least the editor should automatically grow.

See https://cmsimpleforum.com/viewtopic.php?f=10&t=12662.

While image upload (#12) is too tricky to make it into 1.0, embedding images appears to be reasonably doable, and might be a prerequisite for emoticons (#7) in HTML comments.

We must not forget to constrain the image display size to some reasonable value, though, see cmb69/forum_xh#2.

See https://cmsimpleforum.com/viewtopic.php?f=10&t=12662.

Forwarding from cmb69/realblog_xh#68.

Of couse, we have to explicitly declare TWOCENTS, so that there are no issues in strict mode.

Requires topicname to be sent.

It appears that the redirect after adding a new comment doesn't cater to comments_order = DESC, but always goes to the first comment instead. See https://cmsimpleforum.com/viewtopic.php?f=16&t=7933&start=70#p61890.

Das hast du nun davon ...

Ich wünsche mir einen Header über den Kommentaren (Sprachvariable).
Siehe Testseite.

Any Ajax response has to clean and terminate all output buffers; otherwise this may result in extraneous output. Actually, this happens at least if Twocents_XH is used as Realblog_XH comments plugin as of cmb69/realblog_xh@672d25a1

Altough it is documented that twocents() must not be called multiple times on the same page, it can be called multiple times on different pages. Some plugins, such as Onepage_XH evaluate all pages, what causes Twocents_XH's JavaScript to be included and executed multiple times, causing undesirable behavior (such as multiple "Write new comment" buttons). While that's not strictly a bug in Twocents_XH, it appears to be reasonable to prevent multiple script loading in the first place.

Actually, IE does mark up bold and italics, but not as <b> and <i>, but rather as <strong> and <em>, respecitvely. However, these tags are removed by HTMLPurifier.

The clean solution appears to be to convert to a canonical form, but at least we should support both sets.

Obviously, these should not be counted.

Forwarded from cmb69/realblog_xh#66.

To distinguish between an XHR and a "normal" request, currently the post parameter twocents_ajax is used. Sending an X-Requested-With=XMLHttpRequest HTTP header appears to be cleaner.

Writing a new comment stays on the current page, so the new comment might not be displayed. Instead we should post to the last page (which might even be a new page), or offer the possibility to add a comment only on the last page, or something else which is reasonable.

See http://cmsimpleforum.com/viewtopic.php?f=16&t=7933&start=20#p43462.

Neither the buttons nor the confirmation messages are internationalized.

See http://cmsimpleforum.com/viewtopic.php?f=16&t=7933&start=20#p43462.

See http://cmsimpleforum.com/viewtopic.php?f=16&t=7933&start=10#p43103.

Pressing the "Import all comments from the GBook plugin" button reports "Sorry—this feature is not yet implemented." The error message is even internationalized. Either we should actually implement it (somewhat doubtful, as nobody seems to even have reported this issue), or we should get rid of it altogether.

See https://cmsimpleforum.com/viewtopic.php?t=7933&p=58481#p58481.

See http://cmsimpleforum.com/viewtopic.php?f=16&t=7933&start=20#p43462.

See cmsimple-xh/cmsimple-xh#21.

See http://cmsimpleforum.com/viewtopic.php?f=16&t=7933&start=20#p43462.

Hierarchical comments are probably overkill, but reply button and quoting are reasonable.

Commit 3ddb8d7 caused a severe regression of the RealblogBridge, so that Twocents_XH 1.0beta2 doesn't work with Realblog_XH 3.0beta8.

See https://cmsimpleforum.com/viewtopic.php?f=16&t=7933&p=58461#p58461 for a solution.

This appears to be particularly interesting for archived articles of Realblog_XH, but seems to be of interest otherwise, too, see https://cmsimpleforum.com/viewtopic.php?f=16&t=12462.

This has to be optional, of course, and ideally it should be possible to specify a user group or an access level. Using a general Memberpages/Register-API would be preferable.

See http://cmsimpleforum.com/viewtopic.php?f=12&t=10750.

Bei Überschreiten von pagination_max folgt:

Fatal error: Call to undefined function xdebug_break() in ... \plugins\twocents\views\pagination.php on line 4

HTMLPurifier expects the directory standalone/HTMLPurifier/DefinitionCache/Serializer/ to exist, but it doesn't since we moved to Git, because the directory is empty by default.

The admin tools (edit, show, hide) should set a URL fragment, so the browser jumps to the chosen comment. That would of course require to set an appropriate ID, as it's done for comments in view mode.

Otherwise there will be fatal PHP errors.

See http://cmsimpleforum.com/viewtopic.php?f=16&t=7933&p=43477#p43477.

Habe gerade twocents-master mit realblog-master zusammen versucht.
Keine Kommentare angezeigt und keine Möglichkeit Kommentare zu schreiben.
?
Geht das im Moment noch nicht?

• import images
• prevent duplicate import
• avoid prohibited topicnames

See http://cmsimpleforum.com/viewtopic.php?f=29&t=7970.

See http://3-magi.net/demo/interaction/de/?Twocents_XH#twocents_comment_53dc793d8ed0b.

See http://3-magi.net/demo/interaction/de/?Twocents_XH#twocents_comment_53dc5922dd3a8.