cmeeren / batchit Goto Github PK

For example, will the exception get routed back to each caller?

In the Option module we have Option.defaultWith that takes a thunk.

Perhaps there should be an overload to Batch.Create where notFound is a thunk?

This would help in two ways:

1. If the notFound value is expensive we can avoid creating it
2. If we know that every request will be fulfilled, we have the opportunity to throw an exception instead

What do you think?

I can't see anything around caching in the docs, however this is a common use-case for tasks that BatchIt is also useful for.

The idea would be that cached requests could resolve immediately and only un-cached requests would hit the batching mechanism.

I don't think that any sophisticated cache expiry logic is required, since (at least in my use-case) Batch objects only live as long as a user request anyway.

Assuming the request object is the cache key, this would require that requests implement comparison. I think having the requests be simple data types is a good practice anyway.

What are your thoughts on this?

Would a PR in this area be accepted?