bug: Response.location doesn't exist about opine

[marc2332]

Thanks ! it worked!

app.get('/redirect',(req,res)=>{
	(res as any).location("/home").sendStatus(301);
})

[asos-craigmorten]

Thanks ! it worked!

app.get('/redirect',(req,res)=>{
	(res as any).location("/home").sendStatus(301);
})

Released in version 0.5.1 - if you pull done the latest, you will no longer need the any type casting.

[asos-craigmorten]

Hi @marc2332 I'll take a look at that now - it is most likely a bug 😂

[asos-craigmorten]

Ah! @marc2332 so there is a small bug in the type definitions which is why your IDE is likely complaining that location does not exist (I had forgotten to uncomment since implementing the method!)

As to why (even if you wrote something like (res as any).location("/home")) this isn't redirecting, it is because res.location() just sets a Location header as per the Opine docs.

If you want to perform a redirect, you need to send a response yourself (see https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Location), specifically a status code of 201 or 3xx depending on the reason for redirecting.

I am updating the types now and will add an example for using the res.location() method which will look something like:

const app = opine();

app.get("/home", function (req, res, next) {
  res.send("Hello Deno!");
});

app.get("/redirect", function (req, res, next) {
  res.location("/home").sendStatus(301);
});

app.listen(3000);
console.log("Opine started on port 3000");
console.log("Try opening http://localhost:3000/redirect");

I intend to implement the equivalent of the res.redirect() that Express has very soon.

[asos-craigmorten]

Done. Please refer to the updated API documentation and the location example --> https://github.com/asos-craigmorten/opine/tree/master/examples/location