cmss13-devs / cmss13-pve

---

---

Important

CM-SS13-PVE cannot be compiled exclusively using BYOND - you must use our build tool. Firstly, you need to install BYOND, and run the bin/server.cmd file to start the server. You can learn more in our Installation Guide. Building colonialmarines in DreamMaker directly is now deprecated and will cause errors.

CM-SS13-PVE is a fork of CM-SS13 based on Space Station 13, made in BYOND. CM-SS13-PVE has wildly adapted the SS13 model into a tactical roleplay-based players-versus-AI game. AI code from: https://github.com/Watermelon914/cw-ss13

Useful Links

• Setting up a Development Environment

Tip

Want to contribute for the first time but unsure where to start? Take a look at our community maintained Guide to Contributing!

This guide will get you set up with a Visual Studio Code development environment, complete with BYOND debugger, which will allow you to contribute back to this repository.

• Contributing Rules

This is our canonical, maintainer-maintained contributing guide, which contains information on our maintainer team structure and pull request rules.

• Code Standards

Our standards documents details how to structure your code to comply with CM-SS13 code standards, and provides some information on DreamMaker quirks.

• Code Style

The styles document tells you how to style your code to match the rest of the code in our codebase.

• tgui README

All new interfaces in CM must be created using tgui - this document will help get you set up for tgui development.

Licenses

The code for CM-SS13-PVE is licensed under the GNU Affero General Public License v3. All code is assumed to be licensed under AGPL v3 unless stated otherwise by file header, or this document.

Assets including icons and sound are under the Creative Commons 3.0 BY-SA license unless otherwise indicated. Authorship for assets including art and sound under the CC BY-SA license is defined as the active development team of CM-SS13-PVE unless stated otherwise (by author of the commit).

Commits before 9a001bf520f889b434acd295253a1052420860af on Mon, 14 Sep 2020 09:13:32 +0000 are assumed to be licensed under GNU General Public License v3 and can be used in closed source repositories.

cmss13-pve's Issues

Maintinance jack has no attack cooldown when attacking resin walls

Testmerges

bf56402

Round ID

1583

Description of the bug

Maintenance jack has no click cooldown when it comes to resin walls allowing them to instantly destroy them
https://youtu.be/7vlosS-8KJc

What's the difference with what should have happened?

I should not be able to destroy a wall in 2 seconds

How do we reproduce this bug?

1. Grab a maintenance jack
   2.attack a resin wall fast

...

Issue Bingo

• Issue could be reproduced at least once
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

Flaky test failure with no obvious source

Flaky tests were detected in this test run. This means that there was a failure that was cleared when the tests were simply restarted.
Failures:

Dummies show up on radio backpack

Testmerges

#64: 'Hotfix canmove' by morrowwolf at commit 84db018ff2
#72: 'Projectile smooth movement' by Doubleumc at commit 52c021137b

Round ID

229 on red

Description of the bug

What's the difference with what should have happened?

they shouldn't be there

How do we reproduce this bug?

1. get radio backpack
2. go to marine section
3. look
   ...

Issue Bingo

• Issue could be reproduced at least once
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

Scanner sleepers are improperly set up to their consoles, so are unusable.

          In the sickbay, there's sleepers with body scanner consoles, so as a result, they don't work for either purpose.

Originally posted by @Mark9013100 in #180 (comment)

yeah.

Flaky test failure with no obvious source

Flaky tests were detected in this test run. This means that there was a failure that was cleared when the tests were simply restarted.
Failures:

Scooped up mobs can't hear anything from their environment

Testmerges

Doubt those are relevant

Round ID

Ditto

Description of the bug

Sune said he couldn't hear anything around him when he played as a cat and got scooped up
Probably because held mobs get put in a holder item that then gets put in the mob
Locker code has a proc that could be used here, but I don't quite know how to replicate this bug by myself on a local host to try and fix it so I'll leave this here as a reminder

What's the difference with what should have happened?

Should be able to hear

How do we reproduce this bug?

1. get picked up
2. ???
3. Hearing loss

Issue Bingo

• Issue could be reproduced at least once
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

AI impacts server performance when can't reach target

Testmerges

N/A

Round ID

No response

Description of the bug

When an AI-controlled xeno is unable to reach its target it consumes a very large chunk of server performance.

What's the difference with what should have happened?

Three AI xenos should not consume an outsized amount of server performance.

How do we reproduce this bug?

1. Place a target in an isolated, unreachable location.
2. Place an AI xeno such that it cannot reach the target, but has a large area to pathfind in.
3. Observe performance impact.

Issue Bingo

• Issue could be reproduced at least once
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

Carrier AI issue

Testmerges

There were a few but I do not recall which besides Rock's new game mode being one of them

Round ID

No response

Description of the bug

Bug discovered in on-going rounds where the carrier AI has been utilized (although they are rare). Clicking on the carrier as a observer allows you to take control of a human facehugger. I noticed this in an on-going round on Rock's new map and was in fact able to take over as a facehugger in an on-going PVE round, though I made sure to die immediately as it is unintended.

What's the difference with what should have happened?

We don't want human xenos unless it's a pre-planned GM thing, obviously.

How do we reproduce this bug?

1. Observe in an on-going round
2. Sprite click on a carrier
3. Accept to become a player controlled hugger
4. You are now gaming harder than intended

Issue Bingo

• Issue could be reproduced at least once
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

Walkman is not work

Testmerges

i forgor

Round ID

i forgor

Description of the bug

It won't play anything

What's the difference with what should have happened?

it shouldve played music

How do we reproduce this bug?

1.buy walkman
2.insert caset
3.yes
...

Issue Bingo

• Issue could be reproduced at least once
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

Flaky test check_runtimes: [12:44:04]RUNTIME: Cannot execute null.handle speak(). - handset.dm@51

Flaky tests were detected in this test run. This means that there was a failure that was cleared when the tests were simply restarted.
Failures:

check_runtimes: [12:44:04]RUNTIME: Cannot execute null.handle speak(). - handset.dm@51 at code/modules/unit_tests/check_runtimes.dm:10

Flaky test failure with no obvious source

Flaky tests were detected in this test run. This means that there was a failure that was cleared when the tests were simply restarted.
Failures: