Comments (2)
arxanas
commented on May 20, 2024
The new card importer doesn't actually detect tokens. I fixed that, so now it does — but by default, we don't save tokens to the XML file. So in previous versions of Cockatrice, our cards.xml would never have had a token to put into the deck, and thus this issue wouldn't arise.
Should the fix just be to properly detect and not include tokens in our cards.xml, or to include tokens and then not send them?
from cockatrice.
woogerboy21
commented on May 20, 2024
Is there any way you can write up what steps need to be taken to the PR request referenced in this to test the functionality change / differences?
from cockatrice.
Related Issues (20)
- Hide hidden inflrmation of yourself in the log HOT 6
- Prevent cards jumping around while dragging HOT 2
- `CardDragItem` logic for placing piles/groups incorrect
- Better distinction of phantom cards
- Token Creation Issues in Local Play HOT 2
- When the installation path is a preexisting directory Cockatrice is installed alongside files already contained within
- Tapping cards to the left side HOT 2
- As a user registering for a server, when registration fails, I would like the valid registration input fields not to be cleared so that I do not have to reenter everything
- A plaintext export option for decklists HOT 1
- url cache is not used when offline HOT 6
- Secret Voting Feature Request HOT 1
- pop-up window jumps around in single player when dragged around the screen HOT 1
- Card missing in database HOT 3
- Review of builds and download counts HOT 2
- CI: macOS 10.15 builds failing when installing protobuf dependencies HOT 2
- Arrow unable to be deleted after card transforms
- Game is Unplayable, Nonstop flooding of the game HOT 1
- Context menu type persists if right clicking different play spaces with context menu open HOT 1
- Power and toughness not automatically set anymore HOT 9
- Crash on dialogue menu related to owned/attached cards HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cockatrice.