coda1552 / bettas Goto Github PK

Hello! I was running my mod called Blame with Bettas on and it seemed to have found that the bettas's moss ball ConfiguredFeature is not registered. This can be an issue for mod compatibility as under certain conditions, unregistered ConfiguredFeatures can basically prevent other mod's registered ConfiguredFeatures from spawning if in the same generation stage.

By that I mean, if mod A adds an unregistered CF to the ore generation stage and the biome's codec reaches it first, it will choke and basically nuke mob B's registered CFs afterwards. Here's a case where BetterCaves forgot to register their CF and caused several CFs from Oh The Biomes You'll Go to stop spawning in the world: YUNG-GANG/YUNGs-Better-Caves#75

Here's a more detailed explanation of why this happens in the biome's codec:

Specifically, when you call .withConfiguration on a Feature, you create a ConfiguredFeature. This is what should be registered to the WorldgenRegisties at mod init (you can do it in FMLCommonSetupEvent so you have your config ready too if it is needed).

Anyway here's an example from my mod RepurposedStructures of me registering all my ConfiguredFeatures.
https://github.com/TelepathicGrunt/RepurposedStructures/blob/584433a0745338802c84e9f498dc063c1f5505f8/src/main/java/com/telepathicgrunt/repurposedstructures/modinit/RSConfiguredStructures.java#L72-L74

I hope this helps!

Any betta fish spawned with a bucket is unable to be pacified despite all my attempts with moss balls

version: bettas-forge-1.19.2-1.1.0.jar (no other mods installed)

video of this: https://youtu.be/705jEIGPS44

dunno what happened, but forge says it's ur fault
crash-2022-07-23_18.58.29-fml.txt

Dried leaves smoking recipe and campfire recipe are not working because the smelting recipe is incorrectly referenced.
https://github.com/teamfusion/bettas/blob/master/src/main/resources/data/bettas/recipes/dried_leaves_from_campfire_cooking.json
https://github.com/teamfusion/bettas/blob/master/src/main/resources/data/bettas/recipes/dried_leaves_from_smoking.json

Multiple betta variants, most notably the dumbo/elephant ear and the crowntail variants have mismatched pectoral fins, which I believe to be an issue with the texture map.

These mismatched textures are:
variants 8, 17, 20, 26, 30, 31, 32, 33, 34, 36, 38, 39, 40, 41, 42, 43, 53, 54, 55, 56, 58, 73, 74, 75, 76, 77, 81, 82, 83, 84, 89, 90, 91, 92, 95, 96, 97, 99, 103, 104, 105, 106, 112.

Yes I went through all 119 textures to check which ones had problems, yes I have done this multiple times before.