Comments (4)
c4-sponsor
commented on September 2, 2024
saxenism (sponsor) disputed
from 2024-03-zksync-findings.
saxenism
commented on September 2, 2024
The parenthesis is not required as it does not lead to any wrong calculations in any case.
from 2024-03-zksync-findings.
alex-ppg
commented on September 2, 2024
The Warden describes an addition and division that utilizes an implicit order of operations that could have been incorrect.
As the Sponsor outlines and the code confirms, the desired order of operations is that the division occurs before the addition which is the present behaviour rendering this exhibit invalid.
from 2024-03-zksync-findings.
c4-judge
commented on September 2, 2024
alex-ppg marked the issue as unsatisfactory:
Invalid
from 2024-03-zksync-findings.
Related Issues (20)
- Gas Optimizations HOT 3
- No way to retrieve ETH from the contract: HOT 5
- Large transfers may not work with some ERC20 tokens HOT 4
- Gas Optimizations HOT 3
- `L2StandardERC20.sol` has a flaw in token's reinitialization logic cause after a while the governor would not be able to update the token's metadata HOT 4
- QA Report HOT 2
- QA Report HOT 7
- Gas Optimizations HOT 3
- Gas Optimizations HOT 3
- Gas Optimizations HOT 5
- Gas Optimizations HOT 5
- Centralization risks around `Governance.sol` HOT 7
- Deviational use of `useNearCallPanic` while querying `mintEther()` in `ZKSYNC_NEAR_CALL_executeL1Tx()` could cost users all their gas for the execution HOT 4
- Gas Optimizations HOT 3
- QA Report HOT 2
- QA Report HOT 2
- QA Report HOT 2
- QA Report HOT 2
- Upgraded Q -> 2 from #122 [1714762888728] HOT 2
- Upgraded Q -> 2 from #60 [1714762986225] HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 2024-03-zksync-findings.