Comments (6)
The setFxChildTunnel()
function is overridden such that it's ownable. The protocol is not the enemy to itself an will call the setL2TargetDispenser()
function right away to set both fxChildTunnel
and l2TargetDispenser
variables correctly in one shot. After that, the owner is set to a zero address.
Take a look at the corresponding tests, they all call the correct setL2TargetDispenser()
function and have messages sent as expected.
from 2024-05-olas-findings.
kupermind (sponsor) disputed
from 2024-05-olas-findings.
0xA5DF changed the severity to QA (Quality Assurance)
from 2024-05-olas-findings.
Requires an admin error to happen - therefore low
Making setFxChildTunnel()
public is indeed a bit odd, but I guess it's there due to the need to override the parent function
from 2024-05-olas-findings.
0xA5DF marked the issue as grade-c
from 2024-05-olas-findings.
Closing as this is the only QA by the warden
from 2024-05-olas-findings.
Related Issues (20)
- `stakingIncentive` is not transffered onto the next epoch which is a deviation from the spec HOT 7
- Desynchronized Nominee Data After Nominee Removal. HOT 1
- QA Report HOT 2
- QA Report HOT 6
- QA Report HOT 7
- QA Report HOT 1
- Gas Optimizations HOT 2
- QA Report HOT 2
- QA Report HOT 4
- QA Report HOT 6
- QA Report HOT 1
- Upgraded Q -> 2 from #34 [1720018599046] HOT 2
- Upgraded Q -> 2 from #34 [1720018773609] HOT 2
- Upgraded Q -> 2 from #7 [1720019193236] HOT 2
- Upgraded Q -> 2 from #108 [1720182273590] HOT 2
- Upgraded Q -> 2 from #108 [1720182372513] HOT 3
- Upgraded Q -> 2 from #114 [1720183356196] HOT 4
- Lack of support for specific tokens HOT 1
- Upgraded Q -> 2 from #115 [1720340805863] HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 2024-05-olas-findings.