Comments (7)
I'm sorry, but this doesn't meet the standard expected for QA reports.
Too many false findings, and I don't see many valuable findings here.
Leaving as judged.
from 2024-05-olas-findings.
0xA5DF marked the issue as grade-b
from 2024-05-olas-findings.
0xA5DF marked the issue as grade-c
from 2024-05-olas-findings.
✅ Lack of checks for duplicate nominees in addNomineeEVM() and addNomineeNonEVM()
There's a check in the internal function
VoteWeighting.sol: Lack of input validation in getNextAllowedVotingTimes()
There is in the code that you quoted
StakingProxy.sol: Lack of access control for getImplementation() function
It's a view function
from 2024-05-olas-findings.
Hey @0xA5DF Thank you for judging, I notice I made mistakes with a couple of these, but I provided over 90, please re-review as I know most of these are valid. As given you said 3 are invalid there as still 88 that I suggest are valid.
All the best- Kell
from 2024-05-olas-findings.
Those aren't just 3, those are 3 that I found by just skimming over the top of the report.
Have you checked the rest 88 that they're valid before you're asking me to review them?
For example, ✅ Lack of checks for duplicate service IDs in stake()
is also false since staking transfers an ERC721
from 2024-05-olas-findings.
@0xA5DF I made these lows. I understand I made mistakes but you are saying all 91 are invalid? As you skimmed over them. Please re-review the report as I made sure there is a lot more value in it than you are currently expressing. And the 3 you mentioned being invalid. The code snippets I did, I added the changes in each one. The original code isn't optimised in the ways I said. I respectfully ask you to re-evaluate the report and the 91 suggested lows.
All the best- K42
from 2024-05-olas-findings.
Related Issues (20)
- `stakingIncentive` is not transffered onto the next epoch which is a deviation from the spec HOT 7
- setFxChildTunnel Does Not Update l2TargetDispenser in PolygonDepositProcessorL1.sol (Potential Message Loss) HOT 6
- Desynchronized Nominee Data After Nominee Removal. HOT 1
- QA Report HOT 2
- QA Report HOT 6
- QA Report HOT 1
- Gas Optimizations HOT 2
- QA Report HOT 2
- QA Report HOT 4
- QA Report HOT 6
- QA Report HOT 1
- Upgraded Q -> 2 from #34 [1720018599046] HOT 2
- Upgraded Q -> 2 from #34 [1720018773609] HOT 2
- Upgraded Q -> 2 from #7 [1720019193236] HOT 2
- Upgraded Q -> 2 from #108 [1720182273590] HOT 2
- Upgraded Q -> 2 from #108 [1720182372513] HOT 3
- Upgraded Q -> 2 from #114 [1720183356196] HOT 4
- Lack of support for specific tokens HOT 1
- Upgraded Q -> 2 from #115 [1720340805863] HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 2024-05-olas-findings.