code4romania / civichq-api Goto Github PK

In API ajung corect, dar se pierd in baza de date.

It is unclear how config is loaded. Default config needs to be present that can be overruled by admin.

suggestion: https://github.com/lorenwest/node-config

Display name-ul categoriilor are nevoie de diacritice #georgepruteanu

passwords will be hashed in the db

Each time an app is edited or approved, the logo path is updated with the aws storage path.

applogo: logoSavePath + reqBody.applogoname || null

This should happen only if the logo is changed, not all the time, to avoid creating incorrect urls.

see https://github.com/code4romania/civichq-api/pulls

The CivicHQ API should be able to run inside a Docker container alongside the database dependency MySQL.

Missing methods:

• editapp
• approveapp
• apps
• technologies

A new field was added for the apps:

• isActive

Data structure-ul pentru modelul app din approved apps are nevoie si de numele imaginii pentru autorul app-ului.

Fallback logo sa pointeze catre assets/images/default-owner.png

The isActive field is a new field that was recently added for apps. The editApp call should be enhanced to permit editing this field.

• update edit app procedure to include the new field
• update edit app call - update the info to be saved in db

Best practices

• codebase language should be English
• we 💕 unit tests

The technologies field is a new field that was recently added for apps. The editApp call should be enhanced to permit editing this field.

• update edit app procedure to include the new field
• update edit app call - update the info to be saved in db

Best practices

• codebase language should be English
• we 💕 unit tests

Please provide either a database structure creation script (sql) or enable a migration solution on this

A new field should be added for apps:

• update scripts for apps table and add a new column for storing a list of technologies as strings
• update add and edit app calls - update the info to be saved in db when filling in the add app form to include the list of technologies
• update the response returned by all calls for retrieving the apps list or info about an app; add the info from the technologies field

Best practices

• codebase language should be English
• we 💕 unit tests

document API using swagger

Test the most important API calls:

• get apps ➡️ check that all info for apps are retrieved
• add app ➡️ check that all info for the app are saved
• edit app ➡️ check that all info for the app are edited

Useful links:

• https://blog.getpostman.com/2014/03/07/writing-automated-tests-for-apis-using-postman/
• https://blog.getpostman.com/2014/04/17/how-to-write-automated-tests-for-apis-with-postman-part-2/
• https://blog.getpostman.com/2014/05/09/writing-automated-tests-with-postman-part-3/

Let us know if you would like to use a different testing framework 😄

Best practices for reporting new issues:

• add the [Bug] prefix in the title
• clearly mention the steps to reproduce the bug and the expected behaviour

pm2 start api/server is not needed and it actually causes when an error, because it starts the server without configuration.

When trying to add a new app, a 500 server error is received when uploading the new logo.

Refactor S3 bucket authentication for development purposes.
Currently the authentication to the S3 bucket is done using long term access keys and secret key. Needs to be switched to temporary security credentials obtained through IAM roles, to make development a lot more accessible.

Add soft delete functionality

• add archived flag column in db for apps
• add a delete call for apps that will mark an app as archived in db
• only admins have access to this call

Update get apps call for admin

• apps marked as archived should not be displayed for admin

Best practices

• codebase language should be English
• we 💕 unit tests

related to #code4romania/civichq-client#51

A new field should be added for apps:

• update scripts for apps table and add a new column for storing the app status: active/not active
• update add and edit app calls - update the info to be saved in db when filling in the add app form to include the status
• update the response returned by all calls for retrieving the apps list or info about an app; add the info from the status field

Best practices

• codebase language should be English
• we 💕 unit tests

check & review #71

Stale branches to be investigated and merged to develop branch or removed if no longer needed.

https://github.com/code4romania/civichq-api/branches/stale

Imaginile nu sunt available la path-ul /assets/images/cevaceva.png desi acestea se gases pe server dupa adaugarea unui app.

• add a new table in the DB that saves a list of technologies as strings

• add a new endpoint that retrieves the list of technologies from DB

Best practices

• codebase language should be English
• we 💕 unit tests

npm start is currently not possible. Needs to be provided.

Make the API dockerizable