codeandcats / fast-clone

Extremely fast javascript deep cloning function

fast-clone's Issues

Add angular.copy to benchmarks

Add typings

It's 2018 and this library doesn't have typings!

Would be nice to rewrite in TypeScript and just publish the generated .js and .d.ts files.

Replace Green Keeper with Dependabot

Dependabot was recently acquired by Github, has the same features and more so makes sense.

Ability to exclude specific properties

So you could for example, exclude all the properties starting with $ from being cloned.

Angular likes to attach extra '$...' properties to scoped objects, and although there exists angular.copy for cloning objects without the $ props, fast-clone is faster and can be used both on server and client. So would be handy to have.

Benchmark inaccurate

To run the benchmarks I had to lock jsdom to npm install -D [email protected] because benv doesn't specify a version range, and the new jsdom has deprecated methods that were being used by benv.

Anyways, the benchmarks consistently showed rfdc as the fastest approach.

λ ~/Projects/fast-clone/ master* npm run benchmark

> [email protected] benchmark /Users/jack/Projects/fast-clone
> ts-node --files ./support/benchmark

Generating random json data...
Done.

Test data size is:  7.15 MB

Running benchmark 1 of 7... Done
Running benchmark 2 of 7... Done
Running benchmark 3 of 7... Done
Running benchmark 4 of 7... Done
Running benchmark 5 of 7... Done
Running benchmark 6 of 7... Done
Running benchmark 7 of 7... Done

Library          | Time
-----------------|---------
clone            | 2,181 ms
angular.copy     | 1,715 ms
snapshot         | 1,182 ms
lodash.cloneDeep |   197 ms
fast-clone       |   149 ms
deepClone        |   139 ms
rfdc             |    35 ms

Test for dates cloned with same timezone

Comparison with stringify

How does this function perform in comparison with JSON.parse(JSON.stringify(obj))?

Add support for circular structures

This library does not support circular references, but if we could still get the same performance while supporting them it would be great! An alternative would be to add an option to enable it, so that existing users won't be affected and still get the same super-fast cloning.

Minify as part of build/publish

Add ability to specify custom clone function

For handling specific types/paths in the tree, so if there is a particular object for example that you need to create with a specific constructor then you can.

Add support for Regexp objects