GithubHelp home page GithubHelp logo

codepdx_website's People

Contributors

andycwilliams avatar gferderer avatar jared-krajewski avatar nujabes77 avatar ogorman89 avatar xscottxbrownx avatar

Watchers

 avatar  avatar  avatar

codepdx_website's Issues

Create Footer

Feature Description:

Create a Footer for the site including:

  • Logo
  • Organization Name
  • Social media links
    • GitHub
    • Meetup
    • LinkedIn
    • Discord
  • Links
    • About
    • Code of Conduct
    • Contact Us
    • Copyright CODE PDX

Screenshots:

Capture

Additional Context:

Link to Navbar in Figma

Create projects page hero

Describe the Current Behavior/Feature:

Create projects page hero as in Figma (but with white text and the dark gradient overlay that the home page hero uses). It will take me longer to figure out how to change it in Figma so follow styling from home page hero.


Proposed Implementation:

Screenshot 2023-11-02 at 9 59 37 AM

Create Navbar

Feature Description:

Create Navbar for site complete with

  • Logo
  • Org Name
  • Links to other pages
    1. Projects
    2. Volunteers
  • Toggle for light/dark mode

Screenshots:

Screenshot 2023-10-04 at 8 03 47 PM

Additional Context:

Link to Navbar in Figma

Enhancement: Populate footer with links

Describe the Current Behavior/Feature:

Footer currently does not actual destinations in legalLinks section.


Proposed Implementation:

  • Add proper destination to each link
  • Code of conduct can be found here

Important: Code of conduct needs to be updated with CODE PDX-specific language

Enhancement: [Your Title Here]

Describe the Current Behavior/Feature:

Provide a clear and concise description of the current behavior or feature.


Proposed Implementation:

Provide a detailed low level description of how you propose the enhancement should be implemented.

Create Secondary Partners component

Figma link for component:

Our Partners mini-section of Partners section

I split this into #35 for call to action, and #37 for primary and this one will stay for secondary to make a total of 3 issues -Jared


Feature Description:

Create Partners section of homepage containing 2 mini-sections:

  • Our Partners
    • TAO MUST BE ON TOP & DIFFERENT LAYOUT to be a "feature" of sorts
    • Each partner will contain boxs/divs/containers with logos and text

Screenshots:

Screenshot 2023-10-04 at 8 41 22 PM

This section may require multiple components to be built

See in folder structure src > components > home > partners

  • Partners.jsx is the entire section which consists of:
    • PrimaryPartner.jsx primary parter in issue #37
    • SecondaryPartner.jsx x2
    • CallToAction.jsx. call to action in issue #35

Projects Page Styling Enhacement

Describe the Current Behavior/Feature:

  • for technologies listed, make the technologies buttons or pills

Mobile:

  • reduce padding-top of card
  • scale icons or make mobile icons
  • center mobile text
  • gradient sweep longer

Proposed Implementation:

Provide a detailed low level description of how you propose the enhancement should be implemented.

create volunteer page hero

Describe the Current Behavior/Feature:

create volunteer page hero using styling from home page hero (white text and dark overlay)


Proposed Implementation:

Screenshot 2023-11-02 at 10 00 25 AM

Missing vite dependency esbuild

Bug Description:

vite fails to launch development env on mac due to missing vite dependency esbuild


Reproduction Steps:

  1. switch to main
  2. git pull
  3. npm install
  4. npm run dev

Expected Behavior:

Should launch vite like normal.


Actual Behavior:

fails to load esbuild dependency


Screenshots (If applicable):

If possible, add screenshots to help explain the problem.


Possible Solution (optional):

restore all esbuild dependencies that were deleted in #32

Create Our Projects Brief Section

Feature Description:

Related to #8. Creates a section containing shorter descriptions of each project, to be place on the main page.

  • Title
  • Logo
  • Overview
  • Learn More button that links to projects page

Screenshots:

Capture

Enhancement: Adjust size and layout of logos on project page

Describe the Current Behavior/Feature:

Based on @andycwilliams feedback copied below, my image optimization PR #89 which changed some logos from .pngs to .svgs had some unintended layout side effects on the /projects page

Looking good. The file size reductions may not be huge but it makes it more professional. That at standardizing the names.
My only real comments at the moment are kinda nitpicky ones about consistency in the images rendering.
The new PASS logo is pretty large and much closer to the buttons than the others, in both mobile and desktop versions. In fact, they all seem a bit different. The CODE PDX one is a bit on the big side as well.
2024-01-05 2024-01-05 (3) 2024-01-05 (2) 2024-01-05 (1)
I know this is largely because the images themselves are not consistent. But if we could make them more uniform I think that'd look better. Not worth sweating too much over, though. We could come back to it later with higher definition versions, if we wanted.
Also, perhaps this is a good time to organize the images more? There's already a folder just for volunteer images.

@andycwilliams The images you mentioned are both "new" .svgs, and their scale differs from the .png alternates, so it did throw off the layout a little. As for definition the .svgs should scale infinitely so all that should need to happen is for me to adjust their sizes, padding and margin for consistency.

I can easily adjust this, but would prefer to do it in a separate PR. I was going to propose a slight layout change for the project logos on the project page as well, so I could submit those together.

We could certainly add more folders to /assets. How does folders for /heroImages, /partnerLogos, and /projectLogos sound? That would just leave more generic CODE PDX assets in /assets

Images are always finicky. The struggle is eternal.

I'm down if you want to create a separate issue.

I see in the original issue that in assets create desktop and mobile folders is proposed anyway, so it's a good time to add more folders. And yeah those names look fine with me.

Originally posted by @andycwilliams in #89 (comment)


Proposed Implementation:

Make size and layout adjustments as needed to make the /projects page look consistent.

Projects Section Styling Enhacement

Describe the Current Behavior/Feature:

  • Cards should all be the same min-height
  • Reduce padding below logos and text
  • Change codePDX logo to new SVG with CODE PDX
  • Make a clearer SVG of the PASS logo

Proposed Implementation:

Enhancement: place body in container

Describe the Current Behavior/Feature:

currently all page content has no container to limit max width


Proposed Implementation:

Add container over main content in layout and fix bugs that it causes.

[Bug] - Footer overlapping page content

Bug Description:

Footer seems to be fixed to bottom of viewport, overlapping content.


Reproduction Steps:

  1. Open the website

Expected Behavior:

If page content is shorter than screen, footer should be at base of screen.
If content is longer than screen, footer should be after content.


Screenshots (If applicable):

Screenshot 2023-10-21 at 7 42 23 AM

Possible Solution (optional):

Only give fixed position if content is less than screen height.

Enhancement: Vite XSS Vulnerability

Describe the Current Behavior/Feature:

Screen Shot 2024-01-03 at 2 06 13 PM

Update Vite version to close XSS vulnerability recorded in the last npm audit run.


Proposed Implementation:

npm audit fix 😎

Enhancement: finish dark mode theme

Describe the Current Behavior/Feature:

This issue will need nav bar merged in first to update supporting code.

With the nav bar is a dark mode toggle. Right now there is basically enough of a dark mode theme to test that it was set up properly. Needs a full dark mode theme using [MUI dark mode colors] (https://mui.com/material-ui/customization/dark-mode/).

Proposed Implementation:

All of the magic goes in theme.js

Create Projects Page

Feature Description:

Create the Our Projects section that lists info for active and in-development projects.

  • Title
  • Logo
  • Links
    • Deployment page
    • GitHub
    • Social media links (if applicable)
  • Status (Active or In Development label)
  • Overview
  • Technology Used

Screenshots:

Capture

Volunteer Section (home page) Styling Enhacements

Describe the Current Behavior/Feature:

  • The background color of the volunteer card should be the same color as the project cards
  • volunteer card styling and projects cards should be styled consistently
  • Is there a thinner icon in MUI?
  • Button text overlays button in mobile

Proposed Implementation:

Enhancement: CODE PDX logo contrast

Describe the Current Behavior/Feature:

CODE PDX logo in Navbar and Footer don't have enough contrast at some viewports either due to blobs rendering or not, OR light mode vs dark mode.


Proposed Implementation:

Maybe just functionally determining the src file of the image based on conditions?


Screenshot 2023-12-27 at 8 03 35 AM Screenshot 2023-12-27 at 8 03 54 AM Screenshot 2023-12-27 at 8 04 06 AM

Primary Partner Styling Enhacements

Describe the Current Behavior/Feature:

Mobile

  • reduce text size
  • reduce padding

General

  • Increase gradient vertical for TAO
  • reduce padding between value-titles and content in the TAO card

Proposed Implementation:

Accessibility review

Describe the Current Behavior/Feature:

Full accessibility review


Proposed Implementation:

  • All images should have alt tags
  • All asserts should have labels

Events Section Styling Enhacements

Describe the Current Behavior/Feature:

  • Events cards full-width center on mobile
  • Add Google Calendar
  • Fix card styling (to be consistent
  • Center text on mobile
  • Add Calendar title

Proposed Implementation:

Secondary Partner Styling Enhacements

Describe the Current Behavior/Feature:

  • Reduce padding between text and Author
  • Try to reduce card height while keeping them all symmetrical

Proposed Implementation:

Ian's strong options on testimonial Author

  • Remove dash
  • Bold author
  • Center author

Bug: Tests are not well encapsulated/are not cleaned up after completion

When adding tests, calls to window.matchMedia bleed over to all following tests within a file. Each test should be isolated to itself to ensure that the tests are consistent and not affected by unrelated tests or tests in close proximity.


Reproduction Steps:

  1. Run a test on test/components/NavBar/NavMenu.test.jsx. See that it passes.
  2. In test/components/NavBar/NavMenu.test.jsx, move the test named it('renders contacts and civic profile links below 600px' above it('does not render contacts and civic profile links above 600px'.
  3. Run the test on test/components/NavBar/NavMenu.test.jsx again. See that it fails.

Expected Behavior:

The tests should not change their outcomes based on functions/behavior in unrelated tests.


Actual Behavior:

Functions/behavior in tests affect other unrelated tests.


Possible Solution (optional):

  1. Implement an afterEach in a vitest setups file that handles a resetting of window.matchMedia.
  2. Other tests with complex and/or global modifications should be examined to ensure their behaviors are isolated.

Navbar Styling Enhancements

Describe the Current Behavior/Feature:

Update Desktop Navbar

  • update logo and brand implementation
  • Fix color contrast
  • Add home navigation link
  • Donate badge or Support Code PDX for navbar?

Update Mobile Navbar

  • Switched position of hamburger and darkmode switch or move darkmode to hamburger menu
  • Maybe reduce some height of the mobile navbar

Proposed Implementation:

Create basic 404 page

Figma link for component:

None designed yet.


Feature Description:

Creating a 404 page w/ button to navigate back.


Proposed Solution:

Currently, idea is just to have a centered card that says "Page not found" and a button labeled "go back" that works just like browser back button.


Alternative Solutions:

Team discussion and design.


Screenshots (if applicable):

Something to start with like this:
Screenshot 2023-10-22 at 8 24 17 PM

Then, open up for discussion.

Contact us links replaced with form modal

Describe the Current Behavior/Feature:

Current 'contact us' links use mailto links. We want to replace them with an email webform that pops up in a modal


Proposed Implementation:

Maybe email.js

Image size optimization

Describe the Current Behavior/Feature:

  • Render the smallest possible image for each viewpoint
  • Two versions of each image, break on
  • Webp conversions for all jpgs

Proposed Implementation:

  • in assets create desktop and mobile folders

404 Page Enhacement

Describe the Current Behavior/Feature:

  • Remove the card so the 404 page is full width.
  • Maybe a cool 404 image

Proposed Implementation:

  • Maybe serve some NASA API image/info, if you use some API make sure there is a fallback.

Enhancement: Full code review for consistency/optimizations

Describe the Current Behavior/Feature:

Full code review when styling for each section is seemingly complete.

Optimization/Refactors, Spacing (margin/padding in sections and between sections), Text styling/sizing, Buttons.

Most of this being for some sort of consistency/design guide.


Proposed Implementation:

Decide on margin/padding before hand - have base (e.g. 1rem),
Then, decide on design guide - (e.g. triple space between sections {3rem}, double space between header and info in a single section {2rem}, single space between header/text below {1rem}, etc)

Create theme.js file

Feature Description:

Start MaterialUI styling by creating the theme.js file and implementing it in the app. Apply any styling that is already decided.


Screenshots:


Additional Context:

Link to Navbar in Figma

Enhancement: Add axe-core to testing for pages to enhance accessibility regression testing

We use the axe linter at work all the time to implement regression testing, and I think using it in our test suite would be super helpful. I found a matcher for vitest, too.

A lot of work would need to be done to be able to even implement these tests, as I think we would need to bring our pages up to be at 0 failures when using the matchers, first (see #55). But this would be huge for clamping down on pages that are already there and for pages where we've done the work to make them completely accessible.

About Styling Enhacments

Describe the Current Behavior/Feature:

  • Change breakpoint so the image collage and text box stack before the collage starts stacking.
  • Vertically center the text & header section to the image collage

Mobile:

  • Standardize the top/bottom padding between stacked images so it is symmetrical (when they stack there is a gap between the top images and bottom and needs padding change on breakpoint)
  • remove left size text padding on mobile

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.