codeforpdx / codepdx_website Goto Github PK
View Code? Open in Web Editor NEWHome Page: https://www.codepdx.org
Home Page: https://www.codepdx.org
Footer currently does not actual destinations in legalLinks
section.
Important: Code of conduct needs to be updated with CODE PDX-specific language
Provide a clear and concise description of the current behavior or feature.
Provide a detailed low level description of how you propose the enhancement should be implemented.
Our Partners mini-section of Partners section
I split this into #35 for call to action, and #37 for primary and this one will stay for secondary to make a total of 3 issues -Jared
Create Partners section of homepage containing 2 mini-sections:
See in folder structure src > components > home > partners
Mobile:
Provide a detailed low level description of how you propose the enhancement should be implemented.
vite
fails to launch development env on mac due to missing vite
dependency esbuild
Should launch vite
like normal.
fails to load esbuild
dependency
If possible, add screenshots to help explain the problem.
restore all esbuild
dependencies that were deleted in #32
Related to #8. Creates a section containing shorter descriptions of each project, to be place on the main page.
Create call to action section.
Based on @andycwilliams feedback copied below, my image optimization PR #89 which changed some logos from .png
s to .svg
s had some unintended layout side effects on the /projects page
Looking good. The file size reductions may not be huge but it makes it more professional. That at standardizing the names.
My only real comments at the moment are kinda nitpicky ones about consistency in the images rendering.
The new PASS logo is pretty large and much closer to the buttons than the others, in both mobile and desktop versions. In fact, they all seem a bit different. The CODE PDX one is a bit on the big side as well.
![]()
![]()
![]()
I know this is largely because the images themselves are not consistent. But if we could make them more uniform I think that'd look better. Not worth sweating too much over, though. We could come back to it later with higher definition versions, if we wanted.
Also, perhaps this is a good time to organize the images more? There's already a folder just for volunteer images.@andycwilliams The images you mentioned are both "new"
.svg
s, and their scale differs from the.png
alternates, so it did throw off the layout a little. As for definition the.svg
s should scale infinitely so all that should need to happen is for me to adjust their sizes, padding and margin for consistency.I can easily adjust this, but would prefer to do it in a separate PR. I was going to propose a slight layout change for the project logos on the project page as well, so I could submit those together.
We could certainly add more folders to
/assets
. How does folders for/heroImages
,/partnerLogos
, and/projectLogos
sound? That would just leave more generic CODE PDX assets in/assets
Images are always finicky. The struggle is eternal.
I'm down if you want to create a separate issue.
I see in the original issue that in assets create desktop and mobile folders
is proposed anyway, so it's a good time to add more folders. And yeah those names look fine with me.
Originally posted by @andycwilliams in #89 (comment)
Make size and layout adjustments as needed to make the /projects
page look consistent.
Create Primary Partner Component. split from issue #12
currently all page content has no container to limit max width
Add container over main content in layout and fix bugs that it causes.
Footer seems to be fixed to bottom of viewport, overlapping content.
If page content is shorter than screen, footer should be at base of screen.
If content is longer than screen, footer should be after content.
Only give fixed
position if content is less than screen height.
This issue will need nav bar merged in first to update supporting code.
With the nav bar is a dark mode toggle. Right now there is basically enough of a dark mode theme to test that it was set up properly. Needs a full dark mode theme using [MUI dark mode colors] (https://mui.com/material-ui/customization/dark-mode/).
All of the magic goes in theme.js
Mobile
General
Full accessibility review
Currently user receives no feedback when submitting contact form.
Could be a toast or dialog pop-up, anything really.
Ian's strong options on testimonial Author
Updating readme and contributing documentation.
When adding tests, calls to window.matchMedia
bleed over to all following tests within a file. Each test should be isolated to itself to ensure that the tests are consistent and not affected by unrelated tests or tests in close proximity.
test/components/NavBar/NavMenu.test.jsx
. See that it passes.test/components/NavBar/NavMenu.test.jsx
, move the test named it('renders contacts and civic profile links below 600px'
above it('does not render contacts and civic profile links above 600px'
.test/components/NavBar/NavMenu.test.jsx
again. See that it fails.The tests should not change their outcomes based on functions/behavior in unrelated tests.
Functions/behavior in tests affect other unrelated tests.
afterEach
in a vitest setups file that handles a resetting of window.matchMedia
.Adding website to github pages
Update Desktop Navbar
Update Mobile Navbar
None designed yet.
Creating a 404 page w/ button to navigate back.
Currently, idea is just to have a centered card that says "Page not found" and a button labeled "go back" that works just like browser back button.
Team discussion and design.
Something to start with like this:
Then, open up for discussion.
Current 'contact us' links use mailto links. We want to replace them with an email webform that pops up in a modal
Maybe email.js
Full code review when styling for each section is seemingly complete.
Optimization/Refactors, Spacing (margin/padding in sections and between sections), Text styling/sizing, Buttons.
Most of this being for some sort of consistency/design guide.
Decide on margin/padding before hand - have base (e.g. 1rem),
Then, decide on design guide - (e.g. triple space between sections {3rem}, double space between header and info in a single section {2rem}, single space between header/text below {1rem}, etc)
Start MaterialUI styling by creating the theme.js
file and implementing it in the app. Apply any styling that is already decided.
We use the axe linter at work all the time to implement regression testing, and I think using it in our test suite would be super helpful. I found a matcher for vitest, too.
A lot of work would need to be done to be able to even implement these tests, as I think we would need to bring our pages up to be at 0 failures when using the matchers, first (see #55). But this would be huge for clamping down on pages that are already there and for pages where we've done the work to make them completely accessible.
Add CETI to partners as a secondary partner in secondaryPartnerList.js mapping from seconardaryPartners.js should populate it onto page.
https://ceti.institute/
Do whatever it takes!
Mobile:
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.