GithubHelp home page GithubHelp logo

Server Rendering about dev HOT 2 CLOSED

codemirror avatar codemirror commented on July 16, 2024
Server Rendering

from dev.

Comments (2)

marijnh avatar marijnh commented on July 16, 2024

Interesting, but hydrating such a rendering into a working editor would be a whole different problem. Being able to do this would be cool, but, I think, too much extra complexity to be justified by that coolness. So yeah, this is probably out of scope.

from dev.

curran avatar curran commented on July 16, 2024

The hydration problem can be avoided by clearing out and re-building the DOM once the JS loads, like this (which is how the demo does it):

const editorDiv = document.querySelector('#editor');
editorDiv.innerHTML = '';
editorDiv.appendChild(view.dom);

It's not as fancy as React hydration by a long shot, but it works. For my use case I think this is perfectly acceptable as a hydration solution.

I just had another idea. As an alternative to populating global (which doesn't feel quite right anyway) and detecting the Node environment, what if you could pass in document as an optional argument to the EditorView constructor? Something like this:

const dom = new JSDOM(html);   
const document = dom.window.document;
new EditorView(state, document);

If document is passed in, it can be assumed to be from JSDOM, and its presence can be used as the trigger to avoid executing code that's not necessary for just constructing the DOM.

Food for thought!

from dev.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.