GithubHelp home page GithubHelp logo

Comments (6)

ashtom avatar ashtom commented on June 21, 2024

The call to "instance" is surrounded by #ifdef JMC_LEGACY, see here:
https://github.com/codenauts/HockeySDK-iOS/blob/develop/Classes/CNSHockeyManager.m#L69

This macro is not included in the SDK, so the code gets never executed. Is that macro set somewhere in your code?

from hockeysdk-ios.

vvasanth86 avatar vvasanth86 commented on June 21, 2024

No, I havn't defined that macro. I'm using cocoapods to define the dependencies, but I dont think that should make any difference.

from hockeysdk-ios.

ashtom avatar ashtom commented on June 21, 2024

Hm, maybe cocoapods still pulls an older version. Can you compare the code in your copy of CNSHockeyManager.m, method jmcInstance, with this:
https://github.com/codenauts/HockeySDK-iOS/blob/develop/Classes/CNSHockeyManager.m#L64

Do you use JMC at all? If not, a simple fix would be to remove all lines from this method and always return nil.

from hockeysdk-ios.

vvasanth86 avatar vvasanth86 commented on June 21, 2024

@ashtom Looks like cocoapods does indeed pull from an older version. I dont see the JMC_ENABLED macro in my version.

I guess pods spec needs to be updated. Would you mind creating a new tag that we can point to in the pod spec? The latest (2.2.2) tag is atleast 3 months old.

from hockeysdk-ios.

ashtom avatar ashtom commented on June 21, 2024

I updated the podspec and also created the tag. Can you check if it now pulls the right version?

from hockeysdk-ios.

vvasanth86 avatar vvasanth86 commented on June 21, 2024

@ashtom I was finally able to verify this just yesterday. The 2.2.3 version is green on the validation front. Closing this issue. Thanks!

from hockeysdk-ios.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.