codenauts / hockeysdk-ios Goto Github PK

We had a case where code that's executed on startup that reads user specific data from network caused a crash. Because of it, the user couldn't send a crash report because the app would crash too quickly.

It would be helpful if CNSHockeyManagerDelegate had a method that would be called when the user either dismisses the dialog or when the crash report has been sent. That way we could call didCrashInLastSession on startup and if it returns YES, wait for the delegate method to be called before executing most of the startup code.

I noticed that in CNSHockeyManager configureQuincyManager does not set the delegate for sharedQuincyManager.
Without setting the delegate the crashReportDescription method in my app delegate was not firing. (I didn't realize the delegate had not been set because crashReportDescription is part of the CNSHockeyManagerDelegate protocol.)

I added this line to configureQuincyManager:

[[BWQuincyManager sharedQuincyManager] setDelegate:delegate];

(You could add the above line to your app delegate, but it seems counterintuitive.)

We were trying to submit an app yesterday that had HockeySDK (2.2.2), but the app failed validation with the following warning:

"The app references non-public selectors in Payload/.app/: instance"

After a quick search, we found that HockeySDK was referring to 'instance' in legacy JMC connect code. Can you guys fix this?

/Users/tonyarnold/Desktop/AwesomeiOSApp/Vendor/HockeySDK/Classes/CNSHockeyManager.m:66:52: warning: undeclared selector 'sharedInstance' [-Wundeclared-selector]
  if ((jmcClass) && ([jmcClass respondsToSelector:@selector(sharedInstance)])) {
                                                   ^
/Users/tonyarnold/Desktop/AwesomeiOSApp/Vendor/HockeySDK/Classes/CNSHockeyManager.m:67:39: warning: undeclared selector 'sharedInstance' [-Wundeclared-selector]
    return [jmcClass performSelector:@selector(sharedInstance)];
                                      ^
/Users/tonyarnold/Desktop/AwesomeiOSApp/Vendor/HockeySDK/Classes/CNSHockeyManager.m:92:32: warning: undeclared selector 'setCrashReportingEnabled:' [-Wundeclared-selector]
  SEL crashReporterSelector = @selector(setCrashReportingEnabled:);
                               ^
/Users/tonyarnold/Desktop/AwesomeiOSApp/Vendor/HockeySDK/Classes/CNSHockeyManager.m:113:28: warning: undeclared selector 'configureJiraConnect:projectKey:apiKey:' [-Wundeclared-selector]
  SEL configureSelector = @selector(configureJiraConnect:projectKey:apiKey:);
                           ^
4 warnings generated.

It would be great if these selectors could be declared, or if the specific usages of these SELs could be wrapped in clang pragmas to suppress the warnings. Many developers treat warnings as errors in production builds, so this does present as more than an annoyance.

Hi Hockey-Team
as mentioned at the BeMyApp-Contest in Berlin,
I would like to see better descriptions at the HockeySDK, HockeyKit and QuincyKit.
Because a long time I didn't get what HockeySDK was for.

For HockeySDK you could write something like:
Hockey SDK combines HockeyKit for beta distribution and QuincyKit and crash reporting into one product/framework.

For HockeyKit the sentence is good:
HockeyKit: A software update kit for iOS and Android.

For QuincyKit the sentence is good, too:
QuincyKit: Live crash report management for iOS and Mac OS X.

But perhaps you could add something like:
HockeyKit: A software update kit for iOS and Android. See our other product Hockey SDK, which combines HockeyKit and QuincyKit. Or something like this, and a link to the others products would be good too

Maybe you find some better sentences, maybe from a person who is better in english than me ;-)

regards Flori

After adding HockeySDK to my app I started getting consistent crashes after location services dialogs were presented to the user. I made two change to BWHockeyManager.m which seems to have fixed things (thanks NSZombie):

At line 401:
lastCheck_ = tempLastCheck;

Changed to:
self.lastCheck = tempLastCheck;

And at line 405:
lastCheck_ = [NSDate distantPast];

Changed to:
self.lastCheck = [NSDate distantPast];