codepath / site-unit2-project1-music-playlist-explorer-starter Goto Github PK

Overall solid work. As discussed on our 1:1s you prefer a centralized place for feedback, so let's use an issue for this assignment and take it from here.

1. In the README file I recommend removing the Deployed Application link if it's not applicable. Let's probably leave a comment there on the deployment status.
2. Let's try to have the GIF/Vid added to the README next time, here are some tutorials you might find useful - the demo is great though -:

• https://www.youtube.com/watch?v=3RlpVrYt_qE
• https://www.youtube.com/watch?v=EF6fqnnl3Uk

3. Try to make the commit titles more action oriented - What did you do? Infinitive tense works great! You don't need to add next steps. These can be commented. An example, instead of "modal is up", we can do "[HTML][JS] Implement modal design and functionality".
4. Also, adding visual elements to commits, is highly recommended but optional for now - they should describe what your change is doing.
5. Check out for committing commented out code.
6. I recommend reading https://kyleschaeffer.com/css-font-size-em-vs-px-vs-pt-vs-percent
7. General feedback on comments (eg., a50bd01)
8. Some styling comments throughout the commits!

Saw a lot of unused content in the code: empty lines and commented out unused codes
You can get rid of it in your future projects to provide a clean and tidy environment for code reviewer and yourself;)